Specify RefreshBeforeUpdate on partial failures #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Pulumi to v3.178.0.
Pulumi v3.178.0 now supports indicating a resource should be refreshed by default from partial failures. Previously, it was only possible to indicate this on successful provider operations. With this, if a Module CustomResource partially fails during Create (e.g. one of it's children has failed), it can report a partial failure using `ErrorResourceInitFailed` and now indicate that it should be refreshed before being updated. This way, on the next `pulumi up`, the Module resource will be refreshed before `Update` as intended, giving the Module resource an opportunity to "retry" for any of the failed children.
justinvp
commented
Jun 20, 2025
| Id: moduleStateResourceID, | ||
| Properties: props, | ||
| Reasons: reasons, | ||
| RefreshBeforeUpdate: true, |
There was a problem hiding this comment.
Setting RefreshBeforeUpdate for the partial failure case, like what we do for the success case for Create, Read, and Update, e.g.:
pulumi-terraform-module/pkg/modprovider/module.go
Lines 387 to 391 in 79259e0
Zaid-Ajaj
approved these changes
Jun 20, 2025
mjeffryes
pushed a commit
that referenced
this pull request
Jun 20, 2025
This PR updates dependencies to pulumi v3.178.0 and specifies RefreshBeforeUpdate on partial failures (which is now supported in v3.178.0). Previously, it was only possible to indicate RefreshBeforeUpdate on successful provider operations. With this, if a Module CustomResource partially fails during Create (e.g. one of it's children has failed), as part of reporting a partial failure using `ErrorResourceInitFailed`, it can now indicate that it should be refreshed by default. This way, on the next `pulumi up`, the Module resource will be refreshed as intended, giving the Module resource an opportunity to "retry" for any of the failed children.
|
This PR has been shipped in release v0.1.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dependencies to pulumi v3.178.0 and specifies RefreshBeforeUpdate on partial failures (which is now supported in v3.178.0). Previously, it was only possible to indicate RefreshBeforeUpdate on successful provider operations.
With this, if a Module CustomResource partially fails during Create (e.g. one of it's children has failed), as part of reporting a partial failure using
ErrorResourceInitFailed, it can now indicate that it should be refreshed by default. This way, on the nextpulumi up, the Module resource will be refreshed as intended, giving the Module resource an opportunity to "retry" for any of the failed children.This will make #420 work as intended on subsequent
pulumi ups.Part of #342
Reference: pulumi/pulumi#19909