Open
Conversation
pgavlin
force-pushed
the
pgavlin/esc-secrets
branch
from
fc45dd0 to
9a3c360
Compare
tgummerer
reviewed
Jul 25, 2025
Comment on lines
39
to
+48
| secrets: | ||
| PULUMI_ACCESS_TOKEN: { required: false } | ||
| AWS_ACCESS_KEY_ID: { required: false } | ||
| AWS_SECRET_ACCESS_KEY: { required: false } | ||
| AWS_CI_ROLE_ARN: { required: false } | ||
| ARM_CLIENT_ID: { required: false } | ||
| ARM_CLIENT_SECRET: { required: false } | ||
| ARM_SUBSCRIPTION_ID: { required: false } | ||
| ARM_TENANT_ID: { required: false } | ||
| CODECOV_TOKEN: { required: false } | ||
|
|
||
| PULUMI_ACCESS_TOKEN: {required: false} | ||
| AWS_ACCESS_KEY_ID: {required: false} | ||
| AWS_SECRET_ACCESS_KEY: {required: false} | ||
| AWS_CI_ROLE_ARN: {required: false} | ||
| ARM_CLIENT_ID: {required: false} | ||
| ARM_CLIENT_SECRET: {required: false} | ||
| ARM_SUBSCRIPTION_ID: {required: false} | ||
| ARM_TENANT_ID: {required: false} | ||
| CODECOV_TOKEN: {required: false} |
Contributor
There was a problem hiding this comment.
I think this whole section can now be deleted, instead of just changing the formatting?
Member
Author
There was a problem hiding this comment.
Likely so. These changes are tool-generated, though, so I'd prefer to take that as a follow-up if that's alright.
These changes migrate this repo's GitHub Actions Workflows to use ESC secrets instead of GitHub Secrets. The changes are largely mechanical: - Common configuration for all ESC actions within a workflow is added to the workflow's environment variables - Permissions are expanded as necessary for workflows that do not grant `id-token: write` permissions - `read-all` permissions are replaced with the union of all explicit read permissions and `id-token: write` - Default permissions are replaced with `write-all`, which is the equivalent of all explicit write permissions and `id-token: write` - Explicit permissions are modified to grant `id-token: write` - A step that fetches ESC secrets and populates environment variables is added to each step that reads secrets - Direct references to secrets within the job are replaced with references to the step's outputs All ESC actions are configured to fetch secrets from a shared ESC environment that contains secrets migrated from GitHub Actions. The ESC action performs its own OIDC exchange to obtain a Pulumi Access Token.
pgavlin
force-pushed
the
pgavlin/esc-secrets
branch
from
9a3c360 to
4869661
Compare
pgavlin
added
the
impact/no-changelog-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes migrate this repo's GitHub Actions Workflows to use ESC secrets instead of GitHub Secrets.
The changes are largely mechanical:
id-token: writepermissionsread-allpermissions are replaced with the union of all explicit read permissions andid-token: writewrite-all, which is the equivalent of all explicit write permissions andid-token: writeid-token: writeAll ESC actions are configured to fetch secrets from a shared ESC environment that contains secrets migrated from GitHub Actions. The ESC action performs its own OIDC exchange to obtain a Pulumi Access Token.