Draft
Conversation
We already had this capability in the engine, and we use it for language tests (conformance tests). We should use the same capability during normal operation. Fixes #301
iwahbe
force-pushed
the
iwahbe/engine-based-plugin-loading
branch
from
7d8a7e4 to
903cce8
Compare
tgummerer
approved these changes
Dec 3, 2025
| @@ -0,0 +1,6 @@ | |||
| component: runtime | |||
| kind: Improvements | |||
| body: Use the engine for plugin loading, instead of loading another copy of a plugin for type checking. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| body: Use the engine for plugin loading, instead of loading another copy of a plugin for type checking. | |
| body: Use the engine for plugin loading, instead of loading another copy of a plugin for type checking |
Member
|
I'd put off doing this because of the perf cost |
Member
Author
Did we ever measure the perf cost involved? |
Member
|
I did a quick test with some small aws programs and it was a few seconds slower. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already had this capability in the engine, and we use it for language tests (conformance tests). We should use the same capability during normal operation.
Fixes #301