Skip to content

Conversation

@iwahbe
Copy link
Member

@iwahbe iwahbe commented Jan 15, 2025

After enabling tests in CI, I realized they weren't passing (due to #2). This fixes a regression introduced in #2 and updates the tests to the intended changes from #2.

After enabling tests in CI, I realized they weren't passing (due to #2). This fixes a
regression introduced in #2 and updates the tests to the intended changes from #2.
@iwahbe iwahbe requested a review from a team January 15, 2025 10:20
@iwahbe iwahbe self-assigned this Jan 15, 2025
@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.34%. Comparing base (43d3225) to head (50258c5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   70.14%   70.34%   +0.19%     
==========================================
  Files           2        2              
  Lines         134      145      +11     
==========================================
+ Hits           94      102       +8     
- Misses         33       36       +3     
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iwahbe iwahbe merged commit 861c9ce into main Jan 15, 2025
5 checks passed
@iwahbe iwahbe deleted the iwahbe/fix-tests branch January 15, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant