Fix ScheduledSingleThreadExecutor.awaitTermination exception for nano time calculation error#319
Open
MapleMaster wants to merge 3 commits intopuniverse:masterfrom
Open
Fix ScheduledSingleThreadExecutor.awaitTermination exception for nano time calculation error#319MapleMaster wants to merge 3 commits intopuniverse:masterfrom
MapleMaster wants to merge 3 commits intopuniverse:masterfrom
Conversation
…time calculation error
Author
|
It seems Project Loom is very active recently, how about it compare to Quasar? And what's the future plan for Loom and Quasar development? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
ScheduledSingleThreadExecutor.awaitTermination crashes for Thread.join() second parameter nanos out of range, which is calculated wrong in awaitTermination ().
worker.join(millis, (int) (nanos - millis));By the way, nobody ever calls this function? Does it mean we no need to await for a fiber ?