allowing detectors with multiple apriltag families#54
Open
daweim0 wants to merge 1 commit intopupil-labs:mainfrom
Open
allowing detectors with multiple apriltag families#54daweim0 wants to merge 1 commit intopupil-labs:mainfrom
daweim0 wants to merge 1 commit intopupil-labs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bindings.pycallsapriltag_detector_add_family_bits()in a big else-if chain. Thus, after one tag family is added, the rest are skipped and detector objects can only have one Apriltag family. I assume this is a bug, otherwiseself.params["families"] = families.split()(line 299) would make no sense.