This repository was archived by the owner on Jun 5, 2020. It is now read-only.
Stop this erroring in Windows machines#70
Open
patrickkelso wants to merge 3 commits intopuppetlabs-toy-chest:masterfrom
Open
Stop this erroring in Windows machines#70patrickkelso wants to merge 3 commits intopuppetlabs-toy-chest:masterfrom
patrickkelso wants to merge 3 commits intopuppetlabs-toy-chest:masterfrom
Conversation
Contributor
|
This seems to have upset the tests, please look into that. Also the indentation is off. |
Contributor
|
I've recently fixed a similar problem here: puppetlabs/puppetlabs-java@dadc7a6 Note how the tests need to stub Please also take care that the final PR is a single commit by rebasing/squashing everything into one. See here for an explanation: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The facter.util.resolution.which doesn't handle spaces well and this was causing the fact to error out. As Windows isn't a supported platform a confine seems the easiest fix.