-
Notifications
You must be signed in to change notification settings - Fork 5
CONT-1219 : Adding labeller.yml to for adding labels #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jordanbreen28 can you please review as well?
.github/workflows/labeller.yml
Outdated
| name: Labeller | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow will not be triggered just on PRs to this repo, this is a reusable workflow so requires the workflow_call trigger also. Refer to the other workflows in this repo
.github/workflows/labeller.yml
Outdated
| org_membership: puppetlabs | ||
| token: ${{ secrets.IAC_COMMUNITY_LABELER }} | ||
|
|
||
| test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
job name isn't appropriate
| uses: actions/github-script@v6 | ||
| with: | ||
| script: | | ||
| async function getPullRequest() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this logic not be implemented into puppetlabs/community-labeller@v0 and the trigger updated to run on the label created/deleted event in the parent workflow? (by trigger in the parent workflow, I mean like here)
I left some comments on puppetlabs/community-labeller#265 as well.
|
closing this as this logic has been handled in puppetlabs/community-labeller#265 |
Summary
Adding labeller.yml to for adding labels.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist