Skip to content

Conversation

@malikparvez
Copy link
Member

@malikparvez malikparvez commented Jul 12, 2023

Summary

Adding labeller.yml to for adding labels.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@malikparvez malikparvez requested a review from a team as a code owner July 12, 2023 10:55
@malikparvez malikparvez added the feature New feature or request label Jul 12, 2023
Copy link
Contributor

@Ramesh7 Ramesh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordanbreen28 can you please review as well?

name: Labeller

on:
pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow will not be triggered just on PRs to this repo, this is a reusable workflow so requires the workflow_call trigger also. Refer to the other workflows in this repo

org_membership: puppetlabs
token: ${{ secrets.IAC_COMMUNITY_LABELER }}

test:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

job name isn't appropriate

uses: actions/github-script@v6
with:
script: |
async function getPullRequest() {
Copy link
Contributor

@jordanbreen28 jordanbreen28 Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this logic not be implemented into puppetlabs/community-labeller@v0 and the trigger updated to run on the label created/deleted event in the parent workflow? (by trigger in the parent workflow, I mean like here)

I left some comments on puppetlabs/community-labeller#265 as well.

@malikparvez
Copy link
Member Author

closing this as this logic has been handled in puppetlabs/community-labeller#265

@jordanbreen28 jordanbreen28 deleted the CONT-1219_labeller branch July 12, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants