Skip to content

CONT-1219 : fail ci for puppetlabs members if no label #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

CONT-1219 : fail ci for puppetlabs members if no label #265

merged 1 commit into from
Jul 13, 2023

Conversation

@malikparvez
Copy link
Member

@malikparvez malikparvez commented Jul 11, 2023

Adding the support for PR's to fail my puppetlabs members if no label is added manually

@malikparvez malikparvez requested a review from a team as a code owner July 11, 2023 19:37
@malikparvez malikparvez changed the title maint : fail PR my puppetlabs members if no label maint : fail PR for puppetlabs members if no label Jul 11, 2023
@malikparvez malikparvez added the enhancement New feature or request label Jul 11, 2023
@malikparvez malikparvez changed the title maint : fail PR for puppetlabs members if no label maint : fail ci for puppetlabs members if no label Jul 11, 2023
@malikparvez malikparvez self-assigned this Jul 11, 2023
jordanbreen28
jordanbreen28 reviewed Jul 12, 2023
View reviewed changes
@jordanbreen28
Copy link

jordanbreen28 commented Jul 12, 2023 •
edited
Loading

Will this trigger again and pass when a label is added?
Also think it would be a good idea to have this for all PRs if we could check for a label that isn’t the community one; not just our ones :)

@jordanbreen28 jordanbreen28 mentioned this pull request Jul 12, 2023
Closed
5 tasks
@malikparvez
Copy link
Member Author

malikparvez commented Jul 12, 2023

Will this trigger again and pass when a label is added? Also think it would be a good idea to have this for all PRs if we could check for a label that isn’t the community one; not just our ones :)

yes it will trigger when pr is opened, label is added and label is removed and added the changes to consider if the pr has any label other than the community

@malikparvez malikparvez changed the title maint : fail ci for puppetlabs members if no label CONT-1219 : fail ci for puppetlabs members if no label Jul 13, 2023
@malikparvez malikparvez force-pushed the maint_pr_without_label branch from 563a655 to 5ca9c17 Compare July 13, 2023 06:04
@jordanbreen28
Copy link

jordanbreen28 commented Jul 13, 2023

Will this trigger again and pass when a label is added? Also think it would be a good idea to have this for all PRs if we could check for a label that isn’t the community one; not just our ones :)

yes it will trigger when pr is opened, label is added and label is removed and added the changes to consider if the pr has any label other than the community

Nice job! Not sure if i'm missing something but.. I can't see the logic that is checking non-org member PRs that do not have any other label than community.
For example, we would want the workflow to fail on a PR like this one, puppetlabs/puppetlabs-kubernetes#619.

jordanbreen28
jordanbreen28 reviewed Jul 13, 2023
View reviewed changes
jordanbreen28
jordanbreen28 reviewed Jul 13, 2023
View reviewed changes
@malikparvez malikparvez force-pushed the maint_pr_without_label branch from 1f0e927 to 1d695ca Compare July 13, 2023 11:20
@malikparvez malikparvez force-pushed the maint_pr_without_label branch from a752f71 to d9a222a Compare July 13, 2023 11:22
@malikparvez malikparvez merged commit 15af869 into main Jul 13, 2023
@malikparvez malikparvez deleted the maint_pr_without_label branch July 13, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jordanbreen28 jordanbreen28 jordanbreen28 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@malikparvez malikparvez

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malikparvez @jordanbreen28