resolvers/freebsd/virtual.rb: Adding kenv check for bhyve

[spchamp]

This changeset adds a test for bhyve virtualization.

Presently, bhyve VMs would be reported as 'generic' under the 'virtual' key in facter*. This would match the value of the FreeBSD sysctl field kern.vm_guest under bhyve.

This changeset detects the generic case, then providing a string-downcase translation of the smbios.bios.vendor field under FreeBSD kenv. This might typically be the string, 'bhyve'.

This more specialized representation for a bhyve vm might be easier to interpret for its relevance, in Puppet manifest code, contrated to the string, 'generic'.

Candidly, this may have an impact on any existing code that would assume that the value 'generic' will be produced for that key. If this patch was adopted, perhaps the updated behavior could be annotated in the release notes or in documentation?

(cherry picked from commit 98ca8d7)

* when running in a FreeBSD environment, in the VM

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[spchamp]

This patch might be limited in its effects to a FreeBSD VM under bhyve.

It seems that in a Linux VM under bhyve, facter may already report virtual => bhyve. This might be commensurate with the definition of Facter::Util::Facts::HYPERVISORS_HASH.

In effect, the changeset proposed here might serve to bring the behavior for facter installed in a FreeBSD VM installation into alignment with the existing behavior for facter in a Linux VM installation, with either under bhyve.

[CLAassistant]

All committers have signed the CLA.