Utilize the new describe_on_supported_os method #444
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This demonstrates how the new describe_on_supported_os method would change the templates. This is still a draft PR to rspec-puppet-facts (voxpupuli/rspec-puppet-facts#132) and this is to raise awareness.
bastelfreak
reviewed
Jan 26, 2022
| end | ||
| end | ||
| describe_on_supported_os '<%= name %>' do | ||
| it { is_expected.to compile } |
Contributor
There was a problem hiding this comment.
Suggested change
| it { is_expected.to compile } | |
| it { is_expected.to compile.with_all_deps } |
bastelfreak
reviewed
Jan 26, 2022
| it { is_expected.to compile } | ||
| end | ||
| end | ||
| it { is_expected.to compile } |
Contributor
There was a problem hiding this comment.
Suggested change
| it { is_expected.to compile } | |
| it { is_expected.to compile.with_all_deps } |
Contributor
|
Hey @ekohl! Do you still want to carry on with this PR? |
Contributor
Author
|
There was very little positive feedback on this so I'm not planning to pursue it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates how the new describe_on_supported_os method would change the templates. This is still a draft PR to rspec-puppet-facts (voxpupuli/rspec-puppet-facts#132) and this is to raise awareness.
I've also sent a post to Voxpupuli's mailing list