(maint) Use null value with Puppet 7 #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in using the unit test workflows with Puppet modules, we set Puppet 7's PUPPET_FORGE_TOKEN environment variable to '' and in module Gemfiles evaluated `!ENV['PUPPET_FORGE_TOKEN'].to_s.empty?`. However, the latest PDK template's (3.5.1) Gemfile evaluates the PUPPET_FORGE_TOKEN environment variable slightly differently, opting instead to check whether it exists at all: https://github.com/puppetlabs/pdk-templates/blob/3.5.1.2/moduleroot/Gemfile.erb#L63 Ruby confusingly evaluates everything besides false and nil as "truthy," so an empty string (like the one we set for PUPPET_FORGE_TOKEN) is evaluated as true. This commit updates Puppet 7's environment variable to be set to null instead of an empty string to allow the workflow to be used with PDK template 3.5.1
joshcooper
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in using the unit test workflows with Puppet modules, we set Puppet 7's PUPPET_FORGE_TOKEN environment variable to '' and in module Gemfiles evaluated
!ENV['PUPPET_FORGE_TOKEN'].to_s.empty?.However, the latest PDK template's (3.5.1) Gemfile evaluates the PUPPET_FORGE_TOKEN environment variable slightly differently, opting instead to check whether it exists at all:
https://github.com/puppetlabs/pdk-templates/blob/3.5.1.2/moduleroot/Gemfile.erb#L63
Ruby confusingly evaluates everything besides false and nil as "truthy," so an empty string (like the one we set for PUPPET_FORGE_TOKEN) is evaluated as true.
This commit updates Puppet 7's environment variable to be set to null instead of an empty string to allow the workflow to be used with PDK template 3.5.1