(maint) Install Puppet 7 from Puppet Core #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Phoenix modules install Puppet 8 gems from Puppet Core, but Puppet 7 gems from Rubygems. The logic currently used in Phoenix module gemfiles to determine whether to install from Puppet Core differs slightly from that used in the latest PDK (3.5.1) template, causing authentication errors when attempting to install Puppet 7 gems. The current workflow with the new PDK 3.5.1 gemfile logic attempts to install Puppet 7 gems from Puppet Core without passing on the proper credentials. I attempted to bridge the gap with 1499ab9, but I misunderstood how Ruby ingested variables from GitHub Actions. This commit updates unit tests with released Puppet gems to use Puppet Core gems for Puppet 7.
AriaXLi
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Phoenix modules install Puppet 8 gems from Puppet Core, but Puppet 7 gems from Rubygems. The logic currently used in Phoenix module gemfiles to determine whether to install from Puppet Core differs slightly from that used in the latest PDK (3.5.1) template, causing authentication errors when attempting to install Puppet 7 gems.
The current workflow with the new PDK 3.5.1 gemfile logic attempts to install Puppet 7 gems from Puppet Core without passing on the proper credentials.
I attempted to bridge the gap with 1499ab9, but I misunderstood how Ruby ingested variables from GitHub Actions.
This commit updates unit tests with released Puppet gems to use Puppet Core gems for Puppet 7.