Unsafe VerifiedDoubleReference autocorrection

Author: LukasAud

.rubocop_todo.yml

@@ -68,20 +68,6 @@ RSpec/SubjectStub:
   Exclude:
     - 'spec/puppet/resource_api/base_context_spec.rb'
 
-# Offense count: 24
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: constant, string
-RSpec/VerifiedDoubleReference:
-  Exclude:
-    - 'spec/integration/resource_api_spec.rb'
-    - 'spec/puppet/resource_api/property_spec.rb'
-    - 'spec/puppet/resource_api/puppet_context_spec.rb'
-    - 'spec/puppet/resource_api/simple_provider_spec.rb'
-    - 'spec/puppet/resource_api/transport_spec.rb'
-    - 'spec/puppet/resource_api/type_definition_spec.rb'
-    - 'spec/puppet/resource_api_spec.rb'
-
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowedReceivers.

spec/integration/resource_api_spec.rb

@@ -225,7 +225,7 @@ def get(_context)
       # to have a quick check of the working of metaparams here, without having to stand up
       # a complete catalog.
       # See spec/acceptance/metaparam_spec.rb for more in-depth testing with a full puppet apply
-      let(:catalog) { instance_double('Puppet::Resource::Catalog', 'catalog') }
+      let(:catalog) { instance_double(Puppet::Resource::Catalog, 'catalog') }
       let(:instance) do
         type.new(name: 'somename', name2: 'othername', ensure: 'present', boolean: true, integer: 15, float: 1.23,
                  variant_pattern: '0x1234ABCD', url: 'http://www.google.com', sensitive: Puppet::Pops::Types::PSensitiveType::Sensitive.new('a password'),

spec/puppet/resource_api/property_spec.rb

@@ -10,10 +10,10 @@
   let(:type_name) { 'test_name' }
   let(:attribute_name) { 'some_property' }
   let(:data_type) { Puppet::Pops::Types::PStringType.new(nil) }
-  let(:resource) { instance_double('resource') }
+  let(:resource) { instance_double(resource) }
   let(:resource_hash) { { resource: resource } }
   let(:referrable_type) { Puppet::ResourceApi.register_type(name: 'minimal', attributes: {}) }
-  let(:context) { instance_double('Puppet::ResourceApi::PuppetContext') }
+  let(:context) { instance_double(Puppet::ResourceApi::PuppetContext) }
 
   describe '#new(type_name, data_type, attribute_name, resource_hash, referrable_type)' do
     it { expect { described_class.new(nil) }.to raise_error ArgumentError, /wrong number of arguments/ }
@@ -64,8 +64,8 @@
 
     let(:referrable_type_custom_insync) { Puppet::ResourceApi.register_type(name: type_name, attributes: {}, features: ['custom_insync']) }
     let(:custom_insync_attribute_name) { :case_sensitive_string }
-    let(:test_provider_with_insync) { instance_double('provider_with_insync') }
-    let(:test_provider_without_insync) { instance_double('provider_without_insync') }
+    let(:test_provider_with_insync) { instance_double(provider_with_insync) }
+    let(:test_provider_without_insync) { instance_double(provider_without_insync) }
     let(:custom_insync_property_class) do
       # This awkward handling is to enable us to reference the referrable type in expectations
       passable_type_name = type_name

spec/puppet/resource_api/puppet_context_spec.rb

@@ -9,7 +9,7 @@
 
   describe '#device' do
     context 'when a NetworkDevice is configured' do
-      let(:device) { instance_double('Puppet::Util::NetworkDevice::Simple::Device', 'device') }
+      let(:device) { instance_double(Puppet::Util::NetworkDevice::Simple::Device, 'device') }
 
       before do
         allow(Puppet::Util::NetworkDevice).to receive(:current).and_return(device)
@@ -21,8 +21,8 @@
     end
 
     context 'when a Transport::Wrapper device is configured' do
-      let(:device) { instance_double('Puppet::Util::NetworkDevice::Test_device::Device', 'device') }
-      let(:transport) { instance_double('Puppet::Transport::TestDevice', 'transport') }
+      let(:device) { instance_double(Puppet::Util::NetworkDevice::Test_device::Device, 'device') }
+      let(:transport) { instance_double(Puppet::Transport::TestDevice, 'transport') }
 
       before do
         allow(Puppet::Util::NetworkDevice).to receive(:current).and_return(device)

spec/puppet/resource_api/simple_provider_spec.rb

@@ -4,8 +4,8 @@
 require 'puppet/resource_api/simple_provider'
 
 RSpec.describe Puppet::ResourceApi::SimpleProvider do
-  let(:context) { instance_double('Puppet::ResourceApi::BaseContext', 'context') }
-  let(:type_def) { instance_double('Puppet::ResourceApi::TypeDefinition', 'type_def') }
+  let(:context) { instance_double(Puppet::ResourceApi::BaseContext, 'context') }
+  let(:type_def) { instance_double(Puppet::ResourceApi::TypeDefinition, 'type_def') }
   let(:provider_class) do
     Class.new(described_class) do
       def get(context, _names = nil); end

spec/puppet/resource_api/transport_spec.rb

@@ -289,7 +289,7 @@ class Wibble; end
     context 'with a registered transport' do
       let(:attributes) { {} }
       let(:schema) { { name: 'validate', desc: 'a  minimal connection', connection_info: attributes } }
-      let(:schema_def) { instance_double('Puppet::ResourceApi::TransportSchemaDef', 'schema_def') }
+      let(:schema_def) { instance_double(Puppet::ResourceApi::TransportSchemaDef, 'schema_def') }
       let(:context) { instance_double(Puppet::ResourceApi::PuppetContext, 'context') }
 
       before do
@@ -365,7 +365,7 @@ class Wibble; end
         }
       }
     end
-    let(:schema_def) { instance_double('Puppet::ResourceApi::TransportSchemaDef', 'schema_def') }
+    let(:schema_def) { instance_double(Puppet::ResourceApi::TransportSchemaDef, 'schema_def') }
 
     before do
       allow(Puppet::ResourceApi::TransportSchemaDef).to receive(:new).with(schema).and_return(schema_def)

spec/puppet/resource_api/type_definition_spec.rb

@@ -72,7 +72,7 @@
   end
 
   describe '#create_attribute_in' do
-    let(:puppet_type) { instance_double('Puppet::Type', 'example_type') }
+    let(:puppet_type) { instance_double(Puppet::Type, 'example_type') }
     let(:foo_options) do
       {
         type: 'String',

spec/puppet/resource_api_spec.rb

@@ -440,9 +440,9 @@ def set(_context, _changes); end
         end
 
         context 'when loading from a Puppet::Resource' do
-          let(:params) { instance_double('Puppet::Resource', 'resource') }
+          let(:params) { instance_double(Puppet::Resource, 'resource') }
           let(:provider_instance) { instance_double(provider_class, 'provider_instance') }
-          let(:catalog) { instance_double('Unknown', 'catalog') }
+          let(:catalog) { instance_double(Unknown, 'catalog') }
 
           before do
             allow(provider_class).to receive(:new).with(no_args).and_return(provider_instance)
@@ -1441,7 +1441,7 @@ def set(_context, _changes); end
 
     context 'with a device configured' do
       let(:definition) { { name: 'multi_provider', attributes: {} } }
-      let(:device) { instance_double('Puppet::Util::NetworkDevice::Simple::Device', 'device') }
+      let(:device) { instance_double(Puppet::Util::NetworkDevice::Simple::Device, 'device') }
       let(:device_class) { instance_double(Class, 'device_class') }
 
       before do
@@ -1477,8 +1477,8 @@ class OtherDevice; end
 
     context 'with a transport configured' do
       let(:definition) { { name: 'multi_provider', attributes: {} } }
-      let(:transport) { instance_double('Puppet::ResourceApi::Transport::Wrapper', 'transport') }
-      let(:schema_def) { instance_double('Puppet::ResourceApi::TransportSchemaDef', 'schema_def') }
+      let(:transport) { instance_double(Puppet::ResourceApi::Transport::Wrapper, 'transport') }
+      let(:schema_def) { instance_double(Puppet::ResourceApi::TransportSchemaDef, 'schema_def') }
 
       before do
         allow(Puppet::Util::NetworkDevice).to receive(:current).with(no_args).and_return(transport)
@@ -2068,8 +2068,8 @@ def set(_context, changes)
         features: ['remote_resource']
       }
     end
-    let(:provider_class) { instance_double('Class', 'provider_class') }
-    let(:provider) { instance_double('Puppet::Provider::Remoter::Remoter', 'provider_instance') }
+    let(:provider_class) { instance_double(Class, 'provider_class') }
+    let(:provider) { instance_double(Puppet::Provider::Remoter::Remoter, 'provider_instance') }
 
     before do
       stub_const('Puppet::Provider::Remoter', Module.new)
@@ -2102,8 +2102,8 @@ class Wibble; end
       subject(:type) { Puppet::Type.type(:remoter) }
 
       let(:instance) { type.new(name: 'remote_thing', test_string: 'wibble') }
-      let(:wrapper) { instance_double('Puppet::ResourceApi::Transport::Wrapper', 'wrapper') }
-      let(:transport) { instance_double('Puppet::Transport::Wibble', 'transport') }
+      let(:wrapper) { instance_double(Puppet::ResourceApi::Transport::Wrapper, 'wrapper') }
+      let(:transport) { instance_double(Puppet::Transport::Wibble, 'transport') }
 
       before do
         allow(described_class).to receive(:load_provider).and_return(provider)
@@ -2153,7 +2153,7 @@ def set(_context, _changes, noop: false); end
         end
 CODE
     end
-    let(:provider) { instance_double('Puppet::Provider::TestNoopSupport::TestNoopSupport', 'provider') }
+    let(:provider) { instance_double(Puppet::Provider::TestNoopSupport::TestNoopSupport, 'provider') }
 
     before do
       stub_const('Puppet::Provider::TestNoopSupport', Module.new)
@@ -2203,7 +2203,7 @@ def get(_context, _names = nil)
         def set(_context, changes) end
       end
     end
-    let(:provider) { instance_double('Puppet::Provider::TestGetFilter::TestGetFilter', 'provider') }
+    let(:provider) { instance_double(Puppet::Provider::TestGetFilter::TestGetFilter, 'provider') }
 
     before do
       stub_const('Puppet::Provider::TestGetFilter', Module.new)