(RUBOCOP) Unsafe autocorrections

Author: david22swan

spec/integration/resource_api_spec.rb

@@ -239,9 +239,7 @@ def get(_context)
       end
 
       before do
-        allow(catalog).to receive(:resource).and_return nil
-        allow(catalog).to receive(:alias).and_return nil
-        allow(catalog).to receive(:host_config?).and_return true
+        allow(catalog).to receive_messages(resource: nil, alias: nil, host_config?: true)
       end
 
       it('flushes') { expect { instance.flush }.not_to raise_exception }

spec/puppet/resource_api/property_spec.rb

@@ -203,8 +203,7 @@
           allow(resource).to receive(:rsapi_canonicalized_target_state)
           allow(resource).to receive(:rsapi_current_state)
           allow(resource).to receive(:rsapi_title)
-          allow(referrable_type_custom_insync).to receive(:context).and_return(context)
-          allow(referrable_type_custom_insync).to receive(:my_provider).and_return(test_provider_with_insync)
+          allow(referrable_type_custom_insync).to receive_messages(context: context, my_provider: test_provider_with_insync)
         end
 
         context 'when the property is not rsapi_custom_insync_trigger' do

spec/puppet/resource_api/simple_provider_spec.rb

@@ -445,8 +445,7 @@ def delete(context, _name); end
     before do
       allow(context).to receive(:updating).with('title').and_yield
       allow(type_def).to receive(:feature?).with('simple_get_filter')
-      allow(type_def).to receive(:ensurable?).and_return(false)
-      allow(type_def).to receive(:namevars).and_return([:name])
+      allow(type_def).to receive_messages(ensurable?: false, namevars: [:name])
     end
 
     it { expect { provider.set(context, changes) }.to raise_error(/SimpleProvider cannot be used with a Type that is not ensurable/) }

spec/puppet/resource_api/transport/wrapper_spec.rb

@@ -64,8 +64,7 @@ class SomethingSomethingDarkside; end
       let(:transport) { instance_double(Puppet::Transport::TestDevice, 'transport') }
 
       it 'returns the facts provided by the transport' do
-        allow(Puppet::ResourceApi::Transport).to receive(:connect).and_return(transport)
-        allow(Puppet::ResourceApi::Transport).to receive(:list).and_return(schema: :dummy)
+        allow(Puppet::ResourceApi::Transport).to receive_messages(connect: transport, list: { schema: :dummy })
         allow(Puppet::ResourceApi::PuppetContext).to receive(:new).and_return(context)
         allow(transport).to receive(:facts).with(context).and_return(facts)