(RUBOCOP) Autocorrect changes

Author: david22swan

spec/puppet/resource_api/glue_spec.rb

@@ -136,7 +136,7 @@
 
       it { expect(value <=> 'string').to eq(-1) }
       # Avoid this test on jruby 1.7, where it is hitting a implementation inconsistency and `'string' <=> value` returns `nil`
-      it('compares to a string', j17_exclude: true) { expect('string' <=> value).to eq 1 }
+      it('compares to a string', :j17_exclude) { expect('string' <=> value).to eq 1 }
       it { expect(value <=> described_class[b: 'b', c: 'c']).to eq 0 }
       it { expect(value <=> described_class[d: 'd']).to eq(-1) }
       it { expect(value <=> described_class[a: 'a']).to eq 1 }

spec/puppet/resource_api/transport/wrapper_spec.rb

@@ -6,7 +6,7 @@
 require 'puppet/resource_api/transport/wrapper'
 require_relative '../../../fixtures/test_module/lib/puppet/transport/test_device'
 
-RSpec.describe Puppet::ResourceApi::Transport::Wrapper, agent_test: true do
+RSpec.describe Puppet::ResourceApi::Transport::Wrapper, :agent_test do
   describe '#initialize(name, url_or_config)' do
     before do
       module Puppet::Transport

spec/puppet/resource_api/transport_spec.rb

@@ -178,7 +178,7 @@ def change_environment(name = nil)
     end
   end
 
-  describe '#connect(name, connection_info)', agent_test: true do
+  describe '#connect(name, connection_info)', :agent_test do
     let(:name) { 'test_target' }
     let(:schema) do
       {
@@ -274,7 +274,7 @@ class Wibble; end
     end
   end
 
-  describe '#validate(name, connection_info)', agent_test: true do
+  describe '#validate(name, connection_info)', :agent_test do
     context 'when the transport does not exist' do
       it { expect { described_class.send(:validate, 'wibble', {}) }.to raise_error LoadError, %r{(no such file to load|cannot load such file) -- puppet/transport/schema/wibble} }
     end

spec/puppet/resource_api_spec.rb

@@ -38,7 +38,7 @@
       subject(:type) { Puppet::Type.type(:minimal) }
 
       it { is_expected.not_to be_nil }
-      it { is_expected.to be_respond_to :instances }
+      it { is_expected.to respond_to :instances }
       it { expect(type.apply_to).to eq(:host) }
     end
 
@@ -64,7 +64,7 @@
       subject(:type) { Puppet::Type.type(:both) }
 
       it { is_expected.not_to be_nil }
-      it { is_expected.to be_respond_to :instances }
+      it { is_expected.to respond_to :instances }
       it { expect(type.instance_variable_get(:@doc)).to eq 'the docs' }
     end
   end
@@ -279,7 +279,7 @@ def extract_values(function)
         # rubocop:enable Lint/BooleanSymbol
       end
 
-      context 'with a basic provider', agent_test: true do
+      context 'with a basic provider', :agent_test do
         let(:provider_class) do
           Class.new do
             def get(_context)
@@ -322,7 +322,7 @@ def set(_context, _changes); end
           test_enum: 'a', test_variant_pattern: '0xAEF123FF', test_url: 'http://example.com' }
       end
 
-      context 'with a bad provider', agent_test: true do
+      context 'with a bad provider', :agent_test do
         before do
           stub_const('Puppet::Provider::TypeCheck', Module.new)
           stub_const('Puppet::Provider::TypeCheck::TypeCheck', provider_class)
@@ -408,7 +408,7 @@ def set(_context, _changes); end
 
       it('has the secret value is set correctly') { expect(instance[:secret]).to be_a Puppet::Pops::Types::PSensitiveType::Sensitive }
 
-      context 'with a basic provider', agent_test: true do
+      context 'with a basic provider', :agent_test do
         let(:provider_class) do
           Class.new do
             def get(_context)
@@ -471,7 +471,7 @@ def set(_context, _changes); end
     end
   end
 
-  context 'when registering a type that is ensurable', agent_test: true do
+  context 'when registering a type that is ensurable', :agent_test do
     context 'when ensurable is correctly declared' do
       let(:definition) do
         {
@@ -787,7 +787,7 @@ def set(_context, _changes); end
     end
   end
 
-  context 'when registering a type with an `init_only` attribute', agent_test: true do
+  context 'when registering a type with an `init_only` attribute', :agent_test do
     let(:definition) do
       {
         name: 'init_behaviour',
@@ -913,7 +913,7 @@ def set(_context, _changes); end
     end
   end
 
-  context 'when registering a type with an `read_only` attribute', agent_test: true do
+  context 'when registering a type with an `read_only` attribute', :agent_test do
     let(:definition) do
       {
         name: 'read_only_behaviour',
@@ -1022,7 +1022,7 @@ def set(_context, _changes); end
       end
     end
 
-    describe 'a provider that does not return the namevar', agent_test: true do
+    describe 'a provider that does not return the namevar', :agent_test do
       subject(:instance) { Puppet::Type.type(:not_name_namevar) }
 
       let(:provider_class) do
@@ -1048,7 +1048,7 @@ def set(_context, changes) end
     end
   end
 
-  context 'when registering a type with multiple namevars', agent_test: true do
+  context 'when registering a type with multiple namevars', :agent_test do
     let(:name) { 'multiple' }
     let(:title_patterns) { nil }
     let(:definition) do
@@ -1332,7 +1332,7 @@ def set(_context, _changes); end
     end
   end
 
-  context 'when registering a type with a mandatory boolean value', agent_test: true do
+  context 'when registering a type with a mandatory boolean value', :agent_test do
     let(:provider_class) do
       Class.new do
         def get(_context)
@@ -1418,7 +1418,7 @@ def set(_context, _changes); end
     end
   end
 
-  describe '#load_provider', agent_test: true do
+  describe '#load_provider', :agent_test do
     before { described_class.register_type(definition) }
 
     context 'when loading a non-existing provider' do
@@ -1507,7 +1507,7 @@ class OtherDevice; end
     end
   end
 
-  context 'with a provider that does canonicalization', agent_test: true do
+  context 'with a provider that does canonicalization', :agent_test do
     let(:definition) do
       {
         name: 'canonicalizer',
@@ -1714,7 +1714,7 @@ def set(_context, changes)
       end
 
       context 'with a provider that has a custom
-       generate', agent_test: true do
+       generate', :agent_test do
         let(:definition) do
           {
             name: 'generator',
@@ -1798,7 +1798,7 @@ def set(_context, changes)
     end
   end
 
-  context 'with a provider that does not need canonicalization', agent_test: true do
+  context 'with a provider that does not need canonicalization', :agent_test do
     let(:definition) do
       {
         name: 'passthrough',
@@ -1927,7 +1927,7 @@ def set(_context, changes)
     end
   end
 
-  context 'with a provider that does custom insync', agent_test: true do
+  context 'with a provider that does custom insync', :agent_test do
     let(:provider_class) do
       Class.new do
         def insync?(_context, _title, _attribute_name, _is_hash, _should_hash)
@@ -2052,7 +2052,7 @@ def set(_context, changes)
     end
   end
 
-  context 'with a `remote_resource` provider', agent_test: true do
+  context 'with a `remote_resource` provider', :agent_test do
     let(:definition) do
       {
         name: 'remoter',
@@ -2123,7 +2123,7 @@ class Wibble; end
     end
   end
 
-  context 'with a `supports_noop` provider', agent_test: true do
+  context 'with a `supports_noop` provider', :agent_test do
     let(:definition) do
       {
         name: 'test_noop_support',
@@ -2176,7 +2176,7 @@ def set(_context, _changes, noop: false); end
     end
   end
 
-  context 'with a `simple_get_filter` provider', agent_test: true do
+  context 'with a `simple_get_filter` provider', :agent_test do
     let(:definition) do
       {
         name: 'test_get_filter',