(GH-459) Refactor CommandHelper for DebugServer

Previously the command helper was only generating information for the
language server.  Now the the debug server consumes this information too
the helper needs to be refactored to accomodate the new server.

The refactor renames the getRubyEnvFromConfiguration method to
getLanguageServerRubyEnvFromConfiguration

Author: glennsarti

src/handlers/stdio.ts

@@ -26,7 +26,7 @@ export class StdioConnectionHandler extends ConnectionHandler {
   }
 
   createServerOptions(): ServerOptions {
-    let exe: Executable = CommandEnvironmentHelper.getRubyEnvFromConfiguration(
+    let exe: Executable = CommandEnvironmentHelper.getLanguageServerRubyEnvFromConfiguration(
       this.context.asAbsolutePath(this.config.languageServerPath),
       this.settings,
       this.config,

src/handlers/tcp.ts

@@ -22,7 +22,7 @@ export class TcpConnectionHandler extends ConnectionHandler {
     this.logger.debug(`Configuring ${ConnectionType[this.connectionType]}::${this.protocolType} connection handler`);
 
     if (this.connectionType === ConnectionType.Local) {
-      let exe: Executable = CommandEnvironmentHelper.getRubyEnvFromConfiguration(
+      let exe: Executable = CommandEnvironmentHelper.getLanguageServerRubyEnvFromConfiguration(
         this.context.asAbsolutePath(this.config.languageServerPath),
         this.settings,
         this.config,

src/helpers/commandHelper.ts

@@ -7,7 +7,7 @@ import { PuppetInstallType, ProtocolType, IConnectionConfiguration } from '../in
 import { PathResolver } from '../configuration/pathResolver';
 
 export class CommandEnvironmentHelper {
-  public static getRubyEnvFromConfiguration(
+  public static getLanguageServerRubyEnvFromConfiguration(
     languageServerpath: string,
     settings: ISettings,
     config: IConnectionConfiguration,
@@ -17,6 +17,15 @@ export class CommandEnvironmentHelper {
       args: this.buildLanguageServerArguments(languageServerpath, settings),
       options: {},
     };
+    this.applyRubyEnvFromConfiguration(exe, settings, config);
+    return exe;
+  }
+
+  private static applyRubyEnvFromConfiguration(
+    exe: Executable,
+    settings: ISettings,
+    config: IConnectionConfiguration
+  ): Executable {
 
     // setup defaults
     exe.options.env = this.shallowCloneObject(process.env);