(PUP-11993) Style/SymbolProc

This commit enables the Style/SymbolProc cop and fixes 125
(unsafe) autocorrectable offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -728,12 +728,6 @@ Style/StringLiterals:
 Style/SymbolArray:
   Enabled: false
 
-# This cop supports unsafe auto-correction (--auto-correct-all).
-# Configuration parameters: AllowMethodsWithArguments, IgnoredMethods, AllowComments.
-# IgnoredMethods: respond_to, define_method
-Style/SymbolProc:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, AllowSafeAssignment.
 # SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex

lib/puppet/confine/feature.rb

@@ -4,7 +4,7 @@
 
 class Puppet::Confine::Feature < Puppet::Confine
   def self.summarize(confines)
-    confines.collect { |c| c.values }.flatten.uniq.find_all { |value| !confines[0].pass?(value) }
+    confines.collect(&:values).flatten.uniq.find_all { |value| !confines[0].pass?(value) }
   end
 
   # Is the named feature available?

lib/puppet/environments.rb

@@ -313,7 +313,7 @@ def get_conf(name)
     end
 
     def clear_all
-      @loaders.each { |loader| loader.clear_all }
+      @loaders.each(&:clear_all)
     end
   end
 

lib/puppet/face/catalog/select.rb

@@ -44,7 +44,7 @@
       if value.nil? then
         _("no matching resources found")
       else
-        value.map { |x| x.to_s }.join("\n")
+        value.map(&:to_s).join("\n")
       end
     end
   end

lib/puppet/face/module/changes.rb

@@ -38,9 +38,7 @@
       else
         Puppet.warning _("%{count} files modified") % { count: return_value.size }
       end
-      return_value.map do |changed_file|
-        changed_file.to_s
-      end.join("\n")
+      return_value.map(&:to_s).join("\n")
     end
   end
 end

lib/puppet/face/module/list.rb

@@ -117,7 +117,7 @@ def unmet_dependencies(environment)
     end
 
     # Prepare the unmet dependencies for display on the console.
-    environment.modules.sort_by { |mod| mod.name }.each do |mod|
+    environment.modules.sort_by(&:name).each do |mod|
       unmet_grouped = Hash.new { |h, k| h[k] = [] }
       unmet_grouped = mod.unmet_dependencies.each_with_object(unmet_grouped) do |dep, acc|
         acc[dep[:reason]] << dep

lib/puppet/file_serving/mount/locales.rb

@@ -17,7 +17,7 @@ def find(relative_path, request)
   def search(relative_path, request)
     # We currently only support one kind of search on locales - return
     # them all.
-    paths = request.environment.modules.find_all { |mod| mod.locales? }.collect { |mod| mod.locale_directory }
+    paths = request.environment.modules.find_all(&:locales?).collect(&:locale_directory)
     if paths.empty?
       # If the modulepath is valid then we still need to return a valid root
       # directory for the search, but make sure nothing inside it is

lib/puppet/file_serving/mount/pluginfacts.rb

@@ -17,7 +17,7 @@ def find(relative_path, request)
   def search(relative_path, request)
     # We currently only support one kind of search on plugins - return
     # them all.
-    paths = request.environment.modules.find_all { |mod| mod.pluginfacts? }.collect { |mod| mod.plugin_fact_directory }
+    paths = request.environment.modules.find_all(&:pluginfacts?).collect(&:plugin_fact_directory)
     if paths.empty?
       # If the modulepath is valid then we still need to return a valid root
       # directory for the search, but make sure nothing inside it is

lib/puppet/file_serving/mount/plugins.rb

@@ -17,7 +17,7 @@ def find(relative_path, request)
   def search(relative_path, request)
     # We currently only support one kind of search on plugins - return
     # them all.
-    paths = request.environment.modules.find_all { |mod| mod.plugins? }.collect { |mod| mod.plugin_directory }
+    paths = request.environment.modules.find_all(&:plugins?).collect(&:plugin_directory)
     if paths.empty?
       # If the modulepath is valid then we still need to return a valid root
       # directory for the search, but make sure nothing inside it is

lib/puppet/forge.rb

@@ -200,9 +200,7 @@ def tmpdir
     end
 
     def tmpfile
-      @file ||= Tempfile.new(name, Puppet::Forge::Cache.base_path).tap do |f|
-        f.binmode
-      end
+      @file ||= Tempfile.new(name, Puppet::Forge::Cache.base_path).tap(&:binmode)
     end
     # rubocop:enable Naming/MemoizedInstanceVariableName