(PUP-11993) Style/SymbolLiteral

AriaXLi · AriaXLi · commit 9a1fe32d1230 · 2024-03-07T17:05:12.000-08:00
This commit enables the Style/SymbolLiteral cop and fixes 1
autocorrectable offense.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -728,11 +728,6 @@ Style/StringLiterals:
 Style/SymbolArray:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-Style/SymbolLiteral:
-  Exclude:
-    - 'lib/puppet/functions/defined.rb'
-
 # This cop supports unsafe auto-correction (--auto-correct-all).
 # Configuration parameters: AllowMethodsWithArguments, IgnoredMethods, AllowComments.
 # IgnoredMethods: respond_to, define_method
diff --git a/lib/puppet/functions/defined.rb b/lib/puppet/functions/defined.rb
@@ -101,7 +101,7 @@
 # @since 3.8.1 type specific requests with future parser
 # @since 4.0.0
 #
-Puppet::Functions.create_function(:'defined', Puppet::Functions::InternalFunction) do
+Puppet::Functions.create_function(:defined, Puppet::Functions::InternalFunction) do
   dispatch :is_defined do
     scope_param
     required_repeated_param 'Variant[String, Type[CatalogEntry], Type[Type[CatalogEntry]]]', :vals

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@`
`101`	`101`	`# @since 3.8.1 type specific requests with future parser`
`102`	`102`	`# @since 4.0.0`
`103`	`103`	`#`
`104`		`-Puppet::Functions.create_function(:'defined', Puppet::Functions::InternalFunction) do`
	`104`	`+Puppet::Functions.create_function(:defined, Puppet::Functions::InternalFunction) do`
`105`	`105`	`dispatch :is_defined do`
`106`	`106`	`scope_param`
`107`	`107`	`required_repeated_param 'Variant[String, Type[CatalogEntry], Type[Type[CatalogEntry]]]', :vals`