Lint/UriRegexp

Rubocop says "URI.regexp is obsolete and should not be used. Instead, use
"URI::DEFAULT_PARSER.make_regexp". Currently those things are equal:

    URI::DEFAULT_PARSER.make_regexp == URI.regexp
    => true

This prepares us for when URI.regexp goes away in the future.

Author: joshcooper

.rubocop_todo.yml

@@ -712,11 +712,6 @@ Lint/UnusedBlockArgument:
 Lint/UnusedMethodArgument:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-Lint/UriRegexp:
-  Exclude:
-    - 'lib/puppet/pops/pcore.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
 Lint/UselessAccessModifier:

lib/puppet/pops/pcore.rb

@@ -5,7 +5,7 @@ module Puppet::Pops
 module Pcore
   include Types::PuppetObject
 
-  TYPE_URI_RX = Types::TypeFactory.regexp(URI.regexp)
+  TYPE_URI_RX = Types::TypeFactory.regexp(URI::DEFAULT_PARSER.make_regexp)
   TYPE_URI = Types::TypeFactory.pattern(TYPE_URI_RX)
   TYPE_URI_ALIAS = Types::PTypeAliasType.new('Pcore::URI', nil, TYPE_URI)
   TYPE_SIMPLE_TYPE_NAME = Types::TypeFactory.pattern(/\A[A-Z]\w*\z/)