Lint/UnreachableCode

This lint is helpful to show that "just in case" isn't needed.

Author: joshcooper

.rubocop_todo.yml

@@ -696,10 +696,6 @@ Lint/UnderscorePrefixedVariableName:
     - 'lib/puppet/type/file/checksum_value.rb'
     - 'lib/puppet/type/file/content.rb'
 
-Lint/UnreachableCode:
-  Exclude:
-    - 'lib/puppet/provider/package/portupgrade.rb'
-
 # Configuration parameters: AllowedPatterns, IgnoredPatterns.
 # AllowedPatterns: (?-mix:(exactly|at_least|at_most)\(\d+\)\.times)
 Lint/UnreachableLoop:

lib/puppet/provider/package/portupgrade.rb

@@ -155,14 +155,7 @@ def latest
         # Any other error (dump output to log)
         raise Puppet::ExecutionFailure, _("Unexpected output from portversion: %{output}") % { output: output }
       end
-
-      # Just in case we still are running, return nil
-      return nil
     end
-
-    # At this point normal operation has finished and we shouldn't have been called.
-    # Error out and let the admin deal with it.
-    raise Puppet::Error, _("portversion.latest() - fatal error with portversion: %{output}") % { output: output }
   end
 
   ###### Query subcommand - return a hash of details if exists, or nil if it doesn't.