Lint/ShadowedArgument

Lookup.lookup called 'reduce' but it didn't read or modify the 'memo' passed
into the block. It was using 'reduce' as a way to return the first found match,
either returned by 'search_and_merge' or contained in 'default_values'. I think
the code more clearly shows what's going on now.

FileSetting#validate is dead code, remove it.

PortSetting#munge now explicitly passes `value` to super so it's clear the value
is read before overwritten.

Author: joshcooper

.rubocop_todo.yml

@@ -661,13 +661,6 @@ Lint/RescueException:
     - 'lib/puppet/util/command_line/trollop.rb'
     - 'util/rspec_grouper'
 
-# Configuration parameters: IgnoreImplicitReferences.
-Lint/ShadowedArgument:
-  Exclude:
-    - 'lib/puppet/pops/lookup.rb'
-    - 'lib/puppet/settings/file_setting.rb'
-    - 'lib/puppet/settings/port_setting.rb'
-
 Lint/StructNewOverride:
   Exclude:
     - 'lib/puppet/network/http/request.rb'

lib/puppet/pops/lookup.rb

@@ -27,22 +27,26 @@ def self.lookup(name, value_type, default_value, has_default, merge, lookup_invo
     # with name and value.
     not_found = MergeStrategy::NOT_FOUND
     override_values = lookup_invocation.override_values
-    result_with_name = names.reduce([nil, not_found]) do |memo, key|
+    result_with_name = [nil, not_found]
+    names.each do |key|
       value = override_values.include?(key) ? assert_type(["Value found for key '%s' in override hash", key], value_type, override_values[key]) : not_found
       catch(:no_such_key) { value = search_and_merge(key, lookup_invocation, merge, false) } if value.equal?(not_found)
-      break [key, assert_type('Found value', value_type, value)] unless value.equal?(not_found)
-      memo
+      next if value.equal?(not_found)
+
+      result_with_name = [key, assert_type('Found value', value_type, value)]
+      break
     end
 
     # Use the 'default_values' hash as a last resort if nothing is found
     if result_with_name[1].equal?(not_found)
       default_values = lookup_invocation.default_values
       unless default_values.empty?
-        result_with_name = names.reduce(result_with_name) do |memo, key|
+        names.each do |key|
           value = default_values.include?(key) ? assert_type(["Value found for key '%s' in default values hash", key], value_type, default_values[key]) : not_found
-          memo = [key, value]
-          break memo unless value.equal?(not_found)
-          memo
+          next if value.equal?(not_found)
+
+          result_with_name = [key, value]
+          break
         end
       end
     end

lib/puppet/settings/file_setting.rb

@@ -169,18 +169,6 @@ def to_resource
     resource
   end
 
-  # Make sure any provided variables look up to something.
-  def validate(value)
-    return true unless value.is_a? String
-    value.scan(/\$(\w+)/) { |name|
-      name = $1
-      unless @settings.include?(name)
-        raise ArgumentError,
-          _("Settings parameter '%{name}' is undefined") % { name: name }
-      end
-    }
-  end
-
   # @api private
   # @param option [String] Extra file operation mode information to use
   #   (defaults to read-only mode 'r')

lib/puppet/settings/port_setting.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 class Puppet::Settings::PortSetting < Puppet::Settings::IntegerSetting
   def munge(value)
-    value = super
+    value = super(value)
 
     if value < 0 || value > 65535
       raise Puppet::Settings::ValidationError, _("Value '%{value}' is not a valid port number for parameter: %{name}") % { value: value.inspect, name: @name }