Lint/UnreachableLoop

The AtFork tests rely on the `loop` behavior and the code is very
fragile, so exclude.

Author: joshcooper

.rubocop_todo.yml

@@ -645,13 +645,6 @@ Lint/UnderscorePrefixedVariableName:
     - 'lib/puppet/type/file/checksum_value.rb'
     - 'lib/puppet/type/file/content.rb'
 
-# Configuration parameters: AllowedPatterns, IgnoredPatterns.
-# AllowedPatterns: (?-mix:(exactly|at_least|at_most)\(\d+\)\.times)
-Lint/UnreachableLoop:
-  Exclude:
-    - 'lib/puppet/util/at_fork.rb'
-
-# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
 Lint/UnusedBlockArgument:
   Enabled: false

lib/puppet/util/at_fork.rb

@@ -13,7 +13,7 @@
 #   killed in the process as a consequence of running in the same contract as the
 #   service.
 module Puppet::Util::AtFork
-  @handler_class = loop do
+  @handler_class = loop do # rubocop:disable Lint/UnreachableLoop
     if Puppet::Util::Platform.solaris?
       begin
         require_relative 'at_fork/solaris'