(PUP-9648) Remove special handling for puppetserver < 5

Puppetserver 5 and up accept and default to JSON instead of PSON so
there's no reason anymore to check if the server supports it.

Author: joshcooper

lib/puppet/http/service/report.rb

@@ -54,9 +54,6 @@ def put_report(name, report, environment:)
 
     if response.success?
       response
-    elsif !@session.supports?(:report, 'json') && Puppet[:preferred_serialization_format] != 'pson'
-      #TRANSLATORS "pson", "preferred_serialization_format", and "puppetserver" should not be translated
-      raise Puppet::HTTP::ProtocolError.new(_("To submit reports to a server running puppetserver %{server_version}, set preferred_serialization_format to pson") % { server_version: response[Puppet::HTTP::HEADER_PUPPET_VERSION]})
     else
       raise Puppet::HTTP::ResponseError.new(response)
     end

spec/unit/http/service/report_spec.rb

@@ -103,18 +103,5 @@
         expect(err.response.code).to eq(400)
       end
     end
-
-    it 'raises an error if unsuccessful, the server version is < 5, and the current serialization format is not pson' do
-      Puppet[:preferred_serialization_format] = 'json'
-
-      stub_request(:put, url).to_return(status: [400, 'Bad Request'], headers: {'X-Puppet-Version' => '4.2.3' })
-
-      expect {
-        subject.put_report('infinity', report, environment: environment)
-      }.to raise_error do |err|
-        expect(err).to be_an_instance_of(Puppet::HTTP::ProtocolError)
-        expect(err.message).to eq('To submit reports to a server running puppetserver 4.2.3, set preferred_serialization_format to pson')
-      end
-    end
   end
 end

spec/unit/indirector/report/rest_spec.rb

@@ -55,30 +55,4 @@ def report_response
 
     expect(described_class.indirection.save(report)).to eq(["store"])
   end
-
-  describe "when the server major version is less than 5" do
-    it "raises if the save fails and we're not using pson" do
-      Puppet[:preferred_serialization_format] = "json"
-
-      stub_request(:put, uri)
-        .to_return(status: 500,
-                   headers: { 'Content-Type' => 'text/pson', Puppet::HTTP::HEADER_PUPPET_VERSION => '4.10.1' })
-
-      expect {
-        described_class.indirection.save(report)
-      }.to raise_error(Puppet::Error, /To submit reports to a server running puppetserver 4.10.1, set preferred_serialization_format to pson/)
-    end
-
-    it "raises with HTTP 500 if the save fails and we're already using pson", if: Puppet.features.pson? do
-      Puppet[:preferred_serialization_format] = "pson"
-
-      stub_request(:put, uri)
-        .to_return(status: 500,
-                   headers: { 'Content-Type' => 'text/pson', Puppet::HTTP::HEADER_PUPPET_VERSION => '4.10.1' })
-
-      expect {
-        described_class.indirection.save(report)
-      }.to raise_error(Net::HTTPError, /Error 500 on SERVER/)
-    end
-  end
 end