Lint/IdentityComparison

Use Object#equals? to check if 2 objects have the same identity. It returns
false if two objects with different ids have the same values.

Author: joshcooper

.rubocop_todo.yml

@@ -617,13 +617,6 @@ Lint/HashCompareByIdentity:
     - 'lib/puppet/pops/serialization/serializer.rb'
     - 'lib/puppet/pops/types/recursion_guard.rb'
 
-# This cop supports safe auto-correction (--auto-correct).
-Lint/IdentityComparison:
-  Exclude:
-    - 'lib/puppet/parser/resource.rb'
-    - 'lib/puppet/ssl/verifier.rb'
-    - 'lib/puppet/type.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: standard_error, runtime_error

lib/puppet/parser/resource.rb

@@ -156,7 +156,7 @@ def isomorphic?
   def merge(resource)
     # Test the resource scope, to make sure the resource is even allowed
     # to override.
-    unless self.source.object_id == resource.source.object_id || resource.source.child_of?(self.source)
+    unless self.source.equal?(resource.source) || resource.source.child_of?(self.source)
       raise Puppet::ParseError.new(_("Only subclasses can override parameters"), resource.file, resource.line)
     end
 

lib/puppet/ssl/verifier.rb

@@ -30,7 +30,7 @@ def initialize(hostname, ssl_context)
   # @api private
   def reusable?(verifier)
     verifier.instance_of?(self.class) &&
-      verifier.ssl_context.object_id == @ssl_context.object_id
+      verifier.ssl_context.equal?(@ssl_context) # same object?
   end
 
   # Configure the `http` connection based on the current `ssl_context`.

lib/puppet/type.rb

@@ -1417,7 +1417,7 @@ def properties_to_audit(list)
       aliases.each do |other|
         obj = @resource.catalog.resource(@resource.class.name, other)
         if obj
-          unless obj.object_id == @resource.object_id
+          unless obj.equal?(@resource) # same object?
             self.fail("#{@resource.title} can not create alias #{other}: object already exists")
           end
           next