Layout/SpaceInsideRangeLiteral

This commit enables the Rubocop Layout/SpaceInsideRangeLiteral cop and
addresses all offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -22,12 +22,6 @@ I18n/GetText/DecorateStringFormattingUsingPercent:
 I18n/RailsI18n/DecorateString:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-Layout/SpaceInsideRangeLiteral:
-  Exclude:
-    - 'lib/puppet/pops/validation/checker4_0.rb'
-    - 'lib/puppet/util/command_line/trollop.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
 # SupportedStyles: space, no_space

lib/puppet/pops/validation/checker4_0.rb

@@ -651,14 +651,14 @@ def dir_to_names(relative_path)
     # and from the manifests dir there.  This may never get used...
     return BAD_MODULE_FILE unless dir == 'manifests' || dir == 'functions' || dir == 'types' || dir == 'plans'
 
-    names = path_components[2 .. -2] # Directories inside module
+    names = path_components[2..-2] # Directories inside module
     names.unshift(path_components[0]) # Name of the module itself
 
     # Do not include name of module init file at top level of module
     # e.g. <module name>/manifests/init.pp
     filename = path_components[-1]
     if !(path_components.length == 3 && filename == 'init.pp')
-      names.push(filename[0 .. -4]) # Remove .pp from filename
+      names.push(filename[0..-4]) # Remove .pp from filename
     end
 
     names

lib/puppet/util/command_line/trollop.rb

@@ -570,12 +570,12 @@ def each_arg args
 
       until i >= args.length
         if @stop_words.member? args[i]
-          remains += args[i .. -1]
+          remains += args[i..-1]
           return remains
         end
         case args[i]
         when /^--$/ # arg terminator
-          remains += args[(i + 1) .. -1]
+          remains += args[(i + 1)..-1]
           return remains
         when /^--(\S+?)=(.*)$/ # long argument with equals
           yield "--#{$1}", [$2]
@@ -586,7 +586,7 @@ def each_arg args
             num_params_taken = yield args[i], params
             unless num_params_taken
               if @stop_on_unknown
-                remains += args[i + 1 .. -1]
+                remains += args[i + 1..-1]
                 return remains
               else
                 remains += params
@@ -606,7 +606,7 @@ def each_arg args
                 num_params_taken = yield "-#{a}", params
                 unless num_params_taken
                   if @stop_on_unknown
-                    remains += args[i + 1 .. -1]
+                    remains += args[i + 1..-1]
                     return remains
                   else
                     remains += params
@@ -623,7 +623,7 @@ def each_arg args
           end
         else
           if @stop_on_unknown
-            remains += args[i .. -1]
+            remains += args[i..-1]
             return remains
           else
             remains << args[i]
@@ -699,7 +699,7 @@ def wrap_line str, opts = {}
             x = str.index(/\s/, start) if x && x < start
             x || str.length
           end
-        ret << (ret.empty? ? "" : " " * prefix) + str[start ... nextt]
+        ret << (ret.empty? ? "" : " " * prefix) + str[start...nextt]
         start = nextt + 1
       end
       ret