Layout/SpaceInsidePercentLiteralDelimiters

This commit enables the Rubocop
Layout/SpaceInsidePercentLiteralDelimiters cop and addresses all
offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -22,13 +22,6 @@ I18n/GetText/DecorateStringFormattingUsingPercent:
 I18n/RailsI18n/DecorateString:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-Layout/SpaceInsidePercentLiteralDelimiters:
-  Exclude:
-    - 'ext/windows/service/daemon.rb'
-    - 'lib/puppet/interface/documentation.rb'
-    - 'lib/puppet/pops/parser/slurp_support.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 Layout/SpaceInsideRangeLiteral:
   Exclude:

ext/windows/service/daemon.rb

@@ -161,7 +161,7 @@ def report_windows_event(type, id, message)
 
   def parse_runinterval(puppet_path)
     begin
-      runinterval = %x{ #{puppet_path} config --section agent --log_level notice print runinterval }.to_i
+      runinterval = %x{#{puppet_path} config --section agent --log_level notice print runinterval}.to_i
       if runinterval == 0
         runinterval = 1800
         log_err("Failed to determine runinterval, defaulting to #{runinterval} seconds")
@@ -176,7 +176,7 @@ def parse_runinterval(puppet_path)
 
   def parse_log_level(puppet_path, cmdline_debug)
     begin
-      loglevel = %x{ #{puppet_path} config --section agent --log_level notice print log_level }.chomp
+      loglevel = %x{#{puppet_path} config --section agent --log_level notice print log_level}.chomp
       unless loglevel && respond_to?("log_#{loglevel}")
         loglevel = :notice
         log_err("Failed to determine loglevel, defaulting to #{loglevel}")

lib/puppet/interface/documentation.rb

@@ -79,7 +79,7 @@ def build_synopsis(face, action = nil, arguments = nil)
 
         options.each do |option|
           option = get_option(option)
-          wrap = option.required? ? %w{ < > } : %w{ [ ] }
+          wrap = option.required? ? %w{< >} : %w{[ ]}
 
           s.group(0, *wrap) do
             option.optparse.each do |item|
@@ -96,7 +96,7 @@ def build_synopsis(face, action = nil, arguments = nil)
         end
 
         display_global_options.sort.each do |option|
-          wrap = %w{ [ ] }
+          wrap = %w{[ ]}
           s.group(0, *wrap) do
             type = Puppet.settings.setting(option).default
             type ||= Puppet.settings.setting(option).type.to_s.upcase

lib/puppet/pops/parser/slurp_support.rb

@@ -19,9 +19,9 @@ module SlurpSupport
   # unquoted, no escapes
   SLURP_UQNE_PATTERN = /(\$\{?|\z)/m
   SLURP_ALL_PATTERN = /.*(\z)/m
-  SQ_ESCAPES = %w{ \\ ' }
-  DQ_ESCAPES = %w{ \\  $ ' " r n t s u} + ["\r\n", "\n"]
-  UQ_ESCAPES = %w{ \\  $ r n t s u} + ["\r\n", "\n"]
+  SQ_ESCAPES = %w{\\ '}
+  DQ_ESCAPES = %w{\\  $ ' " r n t s u} + ["\r\n", "\n"]
+  UQ_ESCAPES = %w{\\  $ r n t s u} + ["\r\n", "\n"]
 
   def slurp_sqstring
     # skip the leading '