Layout/MultilineMethodCallIndentation

This commit enables the Rubocop Layout/MultilineMethodCallIndentation
cop and addresses all offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -22,12 +22,6 @@ I18n/GetText/DecorateStringFormattingUsingPercent:
 I18n/RailsI18n/DecorateString:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: aligned, indented, indented_relative_to_receiver
-Layout/MultilineMethodCallIndentation:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: symmetrical, new_line, same_line

lib/puppet.rb

@@ -151,9 +151,9 @@ def self.vendored_modules
     dir = Puppet[:vendormoduledir]
     if dir && File.directory?(dir)
       Dir.entries(dir)
-        .reject { |f| f =~ /^\./ }
-        .map { |f| File.join(dir, f, "lib") }
-        .select { |d| FileTest.directory?(d) }
+         .reject { |f| f =~ /^\./ }
+         .map { |f| File.join(dir, f, "lib") }
+         .select { |d| FileTest.directory?(d) }
     else
       []
     end

lib/puppet/file_serving/fileset.rb

@@ -139,8 +139,8 @@ def children
       return [] unless directory?
 
       Dir.entries(path, encoding: Encoding::UTF_8)
-        .reject { |child| ignore?(child) }
-        .collect { |child| down_level(child) }
+         .reject { |child| ignore?(child) }
+         .collect { |child| down_level(child) }
     end
 
     def ignore?(child)

lib/puppet/interface/documentation.rb

@@ -292,7 +292,7 @@ def copyright_owner=(value)
     def copyright_years=(value)
       years = munge_copyright_year value
       years = (years.is_a?(Array) ? years : [years])
-        .sort_by do |x| x.is_a?(Range) ? x.first : x end
+              .sort_by do |x| x.is_a?(Range) ? x.first : x end
 
       @copyright_years = years.map do |year|
         if year.is_a? Range then

lib/puppet/module/plan.rb

@@ -102,7 +102,7 @@ def self.find_files(name, plan_files)
     def self.plans_in_module(pup_module)
       # Search e.g. 'modules/<pup_module>/plans' for all plans
       plan_files = Dir.glob(File.join(pup_module.plans_directory, '*'))
-        .keep_if { |f| valid, _ = is_plans_filename?(f); valid }
+                      .keep_if { |f| valid, _ = is_plans_filename?(f); valid }
 
       plans = plan_files.group_by { |f| plan_name_from_path(f) }
 

lib/puppet/module/task.rb

@@ -211,7 +211,7 @@ def self.is_tasks_executable_filename?(name)
 
     def self.tasks_in_module(pup_module)
       task_files = Dir.glob(File.join(pup_module.tasks_directory, '*'))
-        .keep_if { |f| is_tasks_file?(f) }
+                      .keep_if { |f| is_tasks_file?(f) }
 
       module_executables = task_files.reject(&method(:is_tasks_metadata_filename?)).map.to_a
 

lib/puppet/network/formats.rb

@@ -163,7 +163,7 @@ def render(datum)
       datum.sort_by { |k,_v| k.to_s } .each do |key, value|
         output << key.to_s.ljust(column_a)
         output << json.render(value)
-          .chomp.gsub(/\n */) { |x| x + (' ' * column_a) }
+                      .chomp.gsub(/\n */) { |x| x + (' ' * column_a) }
         output << "\n"
       end
       return output

lib/puppet/network/http/api.rb

@@ -30,9 +30,9 @@ def self.not_found_upgrade
   def self.server_routes
     server_prefix = Regexp.new("^#{Puppet::Network::HTTP::SERVER_URL_PREFIX}/")
     Puppet::Network::HTTP::Route.path(server_prefix)
-      .any
-      .chain(Puppet::Network::HTTP::API::Server::V3.routes,
-             Puppet::Network::HTTP::API.not_found)
+                                .any
+                                .chain(Puppet::Network::HTTP::API::Server::V3.routes,
+                                       Puppet::Network::HTTP::API.not_found)
   end
 
   def self.master_routes

lib/puppet/network/http/api/server/v3.rb

@@ -20,17 +20,17 @@ def self.wrap(&block)
             end
 
             INDIRECTED = Puppet::Network::HTTP::Route
-                .path(/.*/)
-                .any(wrap { Puppet::Network::HTTP::API::IndirectedRoutes.new } )
+                         .path(/.*/)
+                         .any(wrap { Puppet::Network::HTTP::API::IndirectedRoutes.new } )
 
             ENVIRONMENTS = Puppet::Network::HTTP::Route
-                .path(%r{^/environments$})
-                .get(wrap { Environments.new(Puppet.lookup(:environments)) } )
+                           .path(%r{^/environments$})
+                           .get(wrap { Environments.new(Puppet.lookup(:environments)) } )
 
             def self.routes
               Puppet::Network::HTTP::Route.path(%r{v3})
-                  .any
-                  .chain(ENVIRONMENTS, INDIRECTED)
+                                          .any
+                                          .chain(ENVIRONMENTS, INDIRECTED)
             end
           end
         end

lib/puppet/pops/evaluator/collectors/exported_collector.rb

@@ -40,7 +40,7 @@ def collect
       end
 
       found = Puppet::Resource.indirection
-        .search(@type, :host => @scope.compiler.node.name, :filter => @equery, :scope => @scope)
+                              .search(@type, :host => @scope.compiler.node.name, :filter => @equery, :scope => @scope)
 
       found_resources = found.map {|x| x.is_a?(Puppet::Parser::Resource) ? x : x.to_resource(@scope)}