(PUP-11993) Style/NegatedWhile

This commit enables Style/NegatedWhile cop and fixes 6 auto-correctable
offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -629,16 +629,6 @@ Style/MultipleComparison:
 Style/MutableConstant:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-Style/NegatedWhile:
-  Exclude:
-    - 'lib/puppet/file_system/file_impl.rb'
-    - 'lib/puppet/graph/simple_graph.rb'
-    - 'lib/puppet/http/client.rb'
-    - 'lib/puppet/pops/parser/heredoc_support.rb'
-    - 'lib/puppet/pops/types/p_object_type.rb'
-    - 'lib/puppet/scheduler/scheduler.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 Style/NestedModifier:
   Exclude:

lib/puppet/file_system/file_impl.rb

@@ -52,7 +52,7 @@ def exclusive_create(path, mode, &block)
   def exclusive_open(path, mode, options = 'r', timeout = 300, &block)
     wait = 0.001 + (Kernel.rand / 1000)
     written = false
-    while !written
+    until written
       ::File.open(path, options, mode) do |rf|
         if rf.flock(::File::LOCK_EX | ::File::LOCK_NB)
           Puppet.debug { _("Locked '%{path}'") % { path: path } }

lib/puppet/graph/simple_graph.rb

@@ -106,7 +106,7 @@ def tarjan(root, s)
     # decent Ruby stack.
     recur = [{ :node => root }]
 
-    while not recur.empty? do
+    until recur.empty? do
       frame = recur.last
       vertex = frame[:node]
 

lib/puppet/http/client.rb

@@ -365,7 +365,7 @@ def execute_streaming(request, options: {}, &block)
     response = nil
     done = false
 
-    while !done do
+    until done do
       connect(request.uri, options: options) do |http|
         apply_auth(request, basic_auth) if redirects.zero?
 

lib/puppet/pops/parser/heredoc_support.rb

@@ -83,7 +83,7 @@ def heredoc
     # (Endline in EBNF form): WS* ('|' WS*)? ('-' WS*)? endtag WS* \r? (\n|$)
     endline_pattern = /([[:blank:]]*)(?:([|])[[:blank:]]*)?(?:(\-)[[:blank:]]*)?#{Regexp.escape(endtag)}[[:blank:]]*\r?(?:\n|\z)/
     lines = []
-    while !scn.eos? do
+    until scn.eos? do
       one_line = scn.scan_until(/(?:\n|\z)/)
       raise eof_error unless one_line
 

lib/puppet/pops/types/p_object_type.rb

@@ -1111,7 +1111,7 @@ def compressed_members_hash(features)
   # @return [PObjectType] the topmost parent who's #equality_attributes include the given _attr_
   def find_equality_definer_of(attr)
     type = self
-    while !type.nil? do
+    until type.nil? do
       p = type.resolved_parent
       return type unless p.is_a?(PObjectType)
       return type unless p.equality_attributes.include?(attr.name)

lib/puppet/scheduler/scheduler.rb

@@ -8,7 +8,7 @@ def initialize(timer = Puppet::Scheduler::Timer.new)
 
     def run_loop(jobs)
       mark_start_times(jobs, @timer.now)
-      while not enabled(jobs).empty?
+      until enabled(jobs).empty?
         @timer.wait_for(min_interval_to_next_run_from(jobs, @timer.now))
         run_ready(jobs, @timer.now)
       end