Lint/UnderscorePrefixedVariableName

In Ruby, variables should only start with underscore if they are used.

Author: joshcooper

.rubocop_todo.yml

@@ -638,13 +638,6 @@ Lint/ToJSON:
     - 'lib/puppet/network/http/error.rb'
     - 'lib/puppet/pops/serialization/json.rb'
 
-# Configuration parameters: AllowKeywordBlockArguments.
-Lint/UnderscorePrefixedVariableName:
-  Exclude:
-    - 'lib/puppet/pops/types/p_object_type.rb'
-    - 'lib/puppet/type/file/checksum_value.rb'
-    - 'lib/puppet/type/file/content.rb'
-
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
 Lint/UnusedBlockArgument:
   Enabled: false

lib/puppet/pops/types/p_object_type.rb

@@ -424,7 +424,7 @@ def self.feature_type
   #   @param loader [Loaders::Loader,nil] the loader that loaded the type
   #
   # @api private
-  def initialize(_pcore_init_hash, init_hash_expression = nil)
+  def initialize(_pcore_init_hash, init_hash_expression = nil) # rubocop:disable Lint/UnderscorePrefixedVariableName
     if _pcore_init_hash.is_a?(Hash)
       _pcore_init_from_hash(_pcore_init_hash)
       @loader = init_hash_expression unless init_hash_expression.nil?

lib/puppet/type/file/checksum_value.rb

@@ -19,7 +19,7 @@ def insync?(is)
         return true
       end
 
-      checksum_insync?(resource.parameter(:source), is, true) {|_is| super(_is)}
+      checksum_insync?(resource.parameter(:source), is, true) {|inner| super(inner)}
     end
 
     def property_matches?(current, desired)

lib/puppet/type/file/content.rb

@@ -104,7 +104,7 @@ def insync?(is)
       end
 
       contents_prop = resource.parameter(:source) || self
-      checksum_insync?(contents_prop, is, !resource[:content].nil?) {|_is| super(_is)}
+      checksum_insync?(contents_prop, is, !resource[:content].nil?) {|inner| super(inner)}
     end
 
     def property_matches?(current, desired)