Lint/InterpolationCheck (bug)

We were accidentally trying to interpolate a value in a single quoted string.

Author: joshcooper

.rubocop_todo.yml

@@ -628,11 +628,6 @@ Lint/InheritException:
     - 'lib/puppet/util/logging.rb'
     - 'lib/puppet/util/retry_action.rb'
 
-# This cop supports unsafe auto-correction (--auto-correct-all).
-Lint/InterpolationCheck:
-  Exclude:
-    - 'lib/puppet/util/package/version/pip.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 Lint/LiteralInInterpolation:
   Exclude:

lib/puppet/util/package/version/pip.rb

@@ -150,10 +150,10 @@ def compare(this, other)
           return compare(element, other.at(index)) if element != other.at(index)
         end
       elsif (this.is_a? Array) && !(other.is_a? Array)
-        raise Puppet::Error, 'Cannot compare #{this} (Array) with #{other} (#{other.class}). Only ±Float::INFINITY accepted.' unless other.abs == Float::INFINITY
+        raise Puppet::Error, "Cannot compare #{this} (Array) with #{other} (#{other.class}). Only ±Float::INFINITY accepted." unless other.abs == Float::INFINITY
         return other == -Float::INFINITY ? 1 : -1
       elsif !(this.is_a? Array) && (other.is_a? Array)
-        raise Puppet::Error, 'Cannot compare #{this} (#{this.class}) with #{other} (Array). Only ±Float::INFINITY accepted.' unless this.abs == Float::INFINITY
+        raise Puppet::Error, "Cannot compare #{this} (#{this.class}) with #{other} (Array). Only ±Float::INFINITY accepted." unless this.abs == Float::INFINITY
         return this == -Float::INFINITY ? -1 : 1
       end
       this <=> other