Layout/SpaceInsideReferenceBrackets

This commit enables the Rubocop Layout/SpaceInsideReferenceBrackets cop
and addresses all offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -22,24 +22,6 @@ I18n/GetText/DecorateStringFormattingUsingPercent:
 I18n/RailsI18n/DecorateString:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
-# SupportedStyles: space, no_space
-# SupportedStylesForEmptyBrackets: space, no_space
-Layout/SpaceInsideReferenceBrackets:
-  Exclude:
-    - 'lib/puppet/application.rb'
-    - 'lib/puppet/functions/unique.rb'
-    - 'lib/puppet/parser/scope.rb'
-    - 'lib/puppet/pops/evaluator/access_operator.rb'
-    - 'lib/puppet/pops/evaluator/deferred_resolver.rb'
-    - 'lib/puppet/pops/lookup/hiera_config.rb'
-    - 'lib/puppet/pops/parser/locator.rb'
-    - 'lib/puppet/pops/types/string_converter.rb'
-    - 'lib/puppet/resource/type_collection.rb'
-    - 'lib/puppet/util/windows/adsi.rb'
-    - 'lib/puppet/util/windows/process.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: space, no_space

lib/puppet/application.rb

@@ -287,7 +287,7 @@ def run_mode(mode_name = nil)
       return @run_mode if @run_mode and not mode_name
 
       require_relative '../puppet/util/run_mode'
-      @run_mode = Puppet::Util::RunMode[ mode_name || Puppet.settings.preferred_run_mode ]
+      @run_mode = Puppet::Util::RunMode[mode_name || Puppet.settings.preferred_run_mode]
     end
 
     # Sets environment_mode name. When acting as a compiler, the environment mode

lib/puppet/functions/unique.rb

@@ -114,7 +114,7 @@ def unique_hash(hash, &block)
     block = lambda { |v| v } unless block_given?
     result = Hash.new { |h, k| h[k] = { :keys => [], :values => [] } }
     hash.each_pair do |k, v|
-      rc = result[ block.call(v) ]
+      rc = result[block.call(v)]
       rc[:keys] << k
       rc[:values] << v
     end

lib/puppet/parser/scope.rb

@@ -111,7 +111,7 @@ def add_entries_to(target = {}, include_undef = false)
         if (v == :undef || v.nil?) && !include_undef
           target.delete(k)
         else
-          target[ k ] = v
+          target[k] = v
         end
       end
       target
@@ -609,8 +609,8 @@ def lookup_qualified_variable(fqn, options)
     # not found - search inherited scope for class
     leaf_index = fqn.rindex('::')
     unless leaf_index.nil?
-      leaf_name = fqn[ (leaf_index + 2)..-1 ]
-      class_name = fqn[ 0, leaf_index ]
+      leaf_name = fqn[(leaf_index + 2)..-1]
+      class_name = fqn[0, leaf_index]
       begin
         qs = qualified_scope(class_name)
         unless qs.nil?

lib/puppet/pops/evaluator/access_operator.rb

@@ -56,7 +56,7 @@ def access_String(o, scope, keys)
                if k1 < 0
                  EMPTY_STRING
                else
-                 o[ k1, k2 ]
+                 o[k1, k2]
                end
              when 2
                k1 = Utils.to_n(keys[0])
@@ -70,7 +70,7 @@ def access_String(o, scope, keys)
                  k2 = k2 + k1
                  k1 = 0
                end
-               o[ k1, k2 ]
+               o[k1, k2]
              else
                fail(Issues::BAD_STRING_SLICE_ARITY, @semantic.left_expr, { :actual => keys.size })
              end
@@ -120,7 +120,7 @@ def access_Array(o, scope, keys)
         k1 = 0
       end
       # Help ruby always return empty array when asking for a sub array
-      result = o[ k1, k2 ]
+      result = o[k1, k2]
       result.nil? ? [] : result
     else
       fail(Issues::BAD_ARRAY_SLICE_ARITY, @semantic.left_expr, { :actual => keys.size })

lib/puppet/pops/evaluator/deferred_resolver.rb

@@ -102,7 +102,7 @@ def resolve_futures(catalog)
             mark_sensitive_parameters(r, k)
           end
         end
-        overrides[ k ] = resolved
+        overrides[k] = resolved
       end
       r.parameters.merge!(overrides) unless overrides.empty?
     end

lib/puppet/pops/lookup/hiera_config.rb

@@ -108,7 +108,7 @@ def self.symkeys_to_string(struct)
     case (struct)
     when Hash
       map = {}
-      struct.each_pair { |k, v| map[ k.is_a?(Symbol) ? k.to_s : k] = symkeys_to_string(v) }
+      struct.each_pair { |k, v| map[k.is_a?(Symbol) ? k.to_s : k] = symkeys_to_string(v) }
       map
     when Array
       struct.map { |v| symkeys_to_string(v) }

lib/puppet/pops/parser/locator.rb

@@ -291,7 +291,7 @@ def char_length(offset, end_offset)
 
   class LocatorForChars < AbstractLocator
     def offset_on_line(offset)
-      line_offset = line_index[ line_for_offset(offset) - 1 ]
+      line_offset = line_index[line_for_offset(offset) - 1]
       offset - line_offset
     end
 
@@ -335,7 +335,7 @@ def self._pcore_type
     # Returns the offset on line (first offset on a line is 0).
     # Ruby 19 is multibyte but has no character position methods, must use byteslice
     def offset_on_line(offset)
-      line_offset = line_index[ line_for_offset(offset) - 1 ]
+      line_offset = line_index[line_for_offset(offset) - 1]
       @string.byteslice(line_offset, offset - line_offset).length
     end
 

lib/puppet/pops/types/string_converter.rb

@@ -237,7 +237,7 @@ def self.type_rank(t)
     # @returns [Array<String>] a tuple with left, right delimiters
     #
     def delimiter_pair(default = StringConverter::DEFAULT_ARRAY_DELIMITERS)
-      DELIMITER_MAP[ @delimiters || @plus ] || default
+      DELIMITER_MAP[@delimiters || @plus] || default
     end
 
     def to_s

lib/puppet/resource/type_collection.rb

@@ -196,7 +196,7 @@ def find_or_load(name, type)
 
         result = send(type, fqname)
         unless result
-          if @notfound[ fqname ] && Puppet[ :ignoremissingtypes ]
+          if @notfound[fqname] && Puppet[:ignoremissingtypes]
             # do not try to autoload if we already tried and it wasn't conclusive
             # as this is a time consuming operation. Warn the user.
             # Check first if debugging is on since the call to debug_once is expensive
@@ -206,7 +206,7 @@ def find_or_load(name, type)
           else
             fqname = munge_name(fqname)
             result = loader.try_load_fqname(type, fqname)
-            @notfound[ fqname ] = result.nil?
+            @notfound[fqname] = result.nil?
           end
         end
         result