Clundquist/dpkg install options

[clundquist-stripe]

I have a custom .deb that is a little wonky and installs into / so we have /memcached.
We need to set --instdir so that it ends up in the place we expect, however, currently install_options has no effect for dpkg.

I want this to work as you expect:

$memcached_debian_path = "/path/to/memcached/${memcached_debian}"
package { 'memcached':
    ensure          => latest,
    provider        => dpkg,
    source          => $memcached_debian_path,
    install_options => ['--instdir=/path/to/memcached'],
    # ...

Currently, install_options is ignored.

Debug: Executing '/usr/bin/dpkg-query -W --showformat '${Status} ${Package} ${Version}\n' memcached'
Debug: Executing 'dpkg --set-selections'
Debug: Executing '/usr/bin/dpkg --force-confold -i /path/to/memcached/memcached_1.6.19b.deb'

This should honor install_options so that my resource works as intended.

This change is difficult for me to test as we are behind on puppet versions, so I'll need to rely on CI testing and additional testing from maintainers.

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[CLAassistant]

All committers have signed the CLA.

[clundquist-stripe]

I wasn't sure if we want :uninstall_options for purge too, or if that would make things more difficult.

[joshcooper]

Hi @clundquist-stripe thanks for your contribution. This line:

flags += @resource[:uninstall_options]

will append options without any spaces between them. Probably easier to switch flags to an array like args is in the install case and then splat flags like you're doing.

[clundquist-stripe]

Great catch @joshcooper !

[joshcooper]

Thanks! Sorry forgot to mention earlier could you squash your commits and add tests? I just merged a pacman provider change that is similar to this one.

[joshcooper]

Hi @clundquist-stripe could you squash your commits?

[clundquist-stripe]

can do!
I haven't added tests just yet though :(

[joshcooper]

Thanks @clundquist-stripe! Could you add some unit tests to make sure install and uninstall options are getting passed through to the underying dpkg commands as expected? For example, see how this is done for yum:

puppet/spec/unit/provider/package/yum_spec.rb

Line 80 in 47f7f3b

it { is_expected.to be_install_options }

puppet/spec/unit/provider/package/yum_spec.rb

Line 110 in 47f7f3b

describe 'with install_options' do