Install mod_http2 on EL if required #2593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
require-mod_http2
branch
from
3dc79ee to
5c41406
Compare
Collaborator
Author
|
Includes #2594 because without it the tests would immediately fail. |
kenyon
approved these changes
Mar 10, 2025
smortex
previously approved these changes
Mar 10, 2025
bastelfreak
previously approved these changes
Mar 11, 2025
ekohl
dismissed
bastelfreak’s stale review
The merge-base changed after approval.
smortex
previously approved these changes
Mar 19, 2025
In EL8 httpd had a hard requirement on mod_http2 but in EL9 it turned into a weak dependency. While most installs default to installing weak dependencies, it can be disabled by users. OracleLinux even defaults to disabled. EL7 doesn't have http2 at all so the whole class can't be used with it.
ekohl
force-pushed
the
require-mod_http2
branch
from
5c41406 to
3305686
Compare
Collaborator
Author
|
Trivial rebase done. I'd like to get this merged now. |
bastelfreak
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In EL8 httpd had a hard requirement on mod_http2 but in EL9 it turned into a weak dependency. While most installs default to installing weak dependencies, it can be disabled by users (by setting
install_weak_deps=0in/etc/dnf/dnf.conf). OracleLinux even defaults to disabled.EL7 doesn't have http2 at all so the whole class can't be used with it.
Additional Context
Add any additional context about the problem here.
Still a draft, but having a PR makes it easy for me to test.
Related Issues (if any)
Checklist
puppet apply)