Handle repos passed as an array for list format #1215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 9876c31 the parameter repos was changed to no longer allow an empty string. It does allow an array, but that isn't specifically handled for the list format. Fixes: 9876c31 ("Add support for deb822 APT sources (puppetlabs#1167)")
bastelfreak
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In 9876c31 the parameter repos was changed to no longer allow an empty string. It does allow an array, but that isn't specifically handled for the list format.
I'll admit that I didn't verify if it was an issue before and only determined this by reading the code, but now a test case is added as well to ensure it continues working.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Checklist
puppet apply)