patch deferred problem

Author: LukasAud

.github/workflows/ci.yml

@@ -15,5 +15,5 @@ jobs:
     needs: Spec
     uses: "puppetlabs/cat-github-actions/.github/workflows/module_acceptance.yml@main"
     with:
-      flags: "--latest-agent"
+      flags: "--nightly"
     secrets: "inherit"

.github/workflows/nightly.yml

@@ -14,5 +14,5 @@ jobs:
     needs: Spec
     uses: "puppetlabs/cat-github-actions/.github/workflows/module_acceptance.yml@main"
     with:
-      flags: "--latest-agent"
+      flags: "--nightly"
     secrets: "inherit"

lib/puppet/provider/base_dsc_lite/powershell.rb

@@ -3,6 +3,8 @@
 require 'pathname'
 require 'json'
 require_relative '../../../puppet_x/puppetlabs/dsc_lite/powershell_hash_formatter'
+require 'puppet/pops/evaluator/deferred_resolver'
+require 'puppet/node/facts'
 
 Puppet::Type.type(:base_dsc_lite).provide(:powershell) do
   confine feature: :pwshlib
@@ -65,11 +67,68 @@ def ps_manager
     Pwsh::Manager.instance(command(:powershell), Pwsh::Manager.powershell_args, debug: debug_output)
   end
 
+  # Returns true if obj (or any nested value) is a DeferredValue
+  def deep_contains_deferred?(obj)
+    case obj
+    when Puppet::Pops::Evaluator::DeferredValue
+      true
+    when Hash
+      obj.any? { |k, v| deep_contains_deferred?(k) || deep_contains_deferred?(v) }
+    when Array
+      obj.any? { |v| deep_contains_deferred?(v) }
+    when Puppet::Pops::Types::PSensitiveType::Sensitive
+      begin
+        deep_contains_deferred?(obj.unwrap)
+      rescue
+        false
+      end
+    else
+      false
+    end
+  end
+
+  # Resolve any lingering Deferred values in the `properties` parameter
+  def resolve_properties_deferreds!
+    props_param = resource.parameters[:properties]
+    return unless props_param
+
+    props_val = props_param.value
+    return unless deep_contains_deferred?(props_val)
+
+    # Prefer compiler-based resolution when available
+    compiler = Puppet.lookup(:compiler) { nil }
+    if compiler
+      resolved = Puppet::Pops::Evaluator::DeferredResolver.resolve(props_val, compiler)
+      resource[:properties] = resolved
+      return
+    end
+
+    # Fallback: resolve across the whole catalog in place (official API)
+    facts = Puppet::Node::Facts.new(
+      (resource.catalog.respond_to?(:host) && resource.catalog.host) ||
+        Facter.value(:fqdn) || Facter.value(:hostname) || 'localhost',
+      Facter.to_hash,
+    )
+    env = resource.catalog.respond_to?(:environment_instance) ? resource.catalog.environment_instance : nil
+
+    Puppet::Pops::Evaluator::DeferredResolver.resolve_and_replace(facts, resource.catalog, env, true)
+
+    # Refresh our local value after in-place resolution
+    updated = resource.parameters[:properties]
+    resource[:properties] = updated.value if updated
+  rescue => e
+    raise Puppet::Error, "DSC_lite: failed to resolve Deferred values in `properties`: #{e.class}: #{e.message}"
+  end
+
   def exists?
     timeout = set_timeout
     Puppet.debug "Dsc Timeout: #{timeout} milliseconds"
     version = Facter.value(:powershell_version)
     Puppet.debug "PowerShell Version: #{version}"
+
+    # NEW: resolve any lingering DeferredValue in properties
+    resolve_properties_deferreds!
+
     script_content = ps_script_content('test')
     Puppet.debug "\n" + self.class.redact_content(script_content)
 
@@ -97,6 +156,10 @@ def exists?
   def create
     timeout = set_timeout
     Puppet.debug "Dsc Timeout: #{timeout} milliseconds"
+
+    # NEW: resolve any lingering DeferredValue in properties
+    resolve_properties_deferreds!
+
     script_content = ps_script_content('set')
     Puppet.debug "\n" + self.class.redact_content(script_content)