update regex to allow underscores in firewall name#1174
Open
dlware wants to merge 4 commits intopuppetlabs:mainfrom
Open
update regex to allow underscores in firewall name#1174dlware wants to merge 4 commits intopuppetlabs:mainfrom
dlware wants to merge 4 commits intopuppetlabs:mainfrom
Conversation
update reference as well with puppet strings.
|
|
Author
|
Hello All, Any update on this? Seems like a very simple change. Thanks, dlware |
|
Up! Any news? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing Issue #1173
Summary
Updated regex for firewall name to allow the use of underscores.
lib/puppet/type/firewall.rb:136used puppet strings to update REFERENCE.md
Additional Context
Underscores are supported by the underlying applications and in wide use.
Related Issues (if any)
Issue #1173
Checklist
puppet apply)