Add tcp-reset as an allowed option for --reject-with
#1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praj1001
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows
--reject-with tcp-reset. This was allowed before the 7.0 rewrite, but lost and a regression introduced in that cutover.tcp-resetis allowed (man 8 iptables-extensions) since ancient kernel 2.6.14, and is valid on TCP-matching rules. There's no "you can only do this on TCP rules" limitation included in this PR, as it's valid to do (INPUT rule that matches TCP should jump to Xchain) -> (Xchain does a reject without declaring/knowing that it's TCP).Additional Context
Related Issues (if any)
Resolves #1184
Checklist
puppet apply)