(MODULES-11580) Do not combine stderr and stdout when scanning rules #1267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamshinde360
force-pushed
the
MODULES-11580
branch
3 times, most recently
from
2a74cdb to
1310aa9
Compare
shubhamshinde360
force-pushed
the
MODULES-11580
branch
2 times, most recently
from
aadaffc to
e2bb839
Compare
- We get the output of 'ip(6)tables-save' and parse the contents to get the iptables rules. - When stderr is combined with stdout, the output of the command can be unexpected causing issues when parsing. - This commit disables the combination of stdout and stderr for this reason. - Setting 'failonfail' makes sure that any error returned by 'ip(6)tables-save' command is reported as failure to the user without attempting to parse its output. - Adjust rspecs accordingly.
shubhamshinde360
force-pushed
the
MODULES-11580
branch
from
e2bb839 to
3c381b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additional Context
Related Issues (if any)
Checklist
puppet apply)