puppet_runonce: redirect stderr to stdout #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragingra
approved these changes
Dec 4, 2024
Contributor
ragingra
left a comment
ragingra
left a comment
There was a problem hiding this comment.
Thanks for the change. One failing test seems unrelated, happy for it to go in anyway.
In case the Puppet Agent fails, it prints an error to stderr. Previously when running the task, and the agent failed, it would output only normal stdout, which contained only successful changes, and actual errors were hidden.
6 tasks
vchepkov
pushed a commit
to vchepkov/puppetlabs-peadm
that referenced
this pull request
Dec 14, 2024
In case the Puppet Agent fails, it prints an error to stderr. Previously when running the task, and the agent failed, it would output only normal stdout, which contained only successful changes, and actual errors were hidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the Puppet Agent fails, it prints an error to stderr. Previously when running the task, and the agent failed, it would output only normal stdout, which contained only successful changes, and actual errors were hidden.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
Changes include test coverage?
Have you updated the documentation?