(PE-39351) Update add_database plan to work with patching/HAC #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpartlow
reviewed
Dec 11, 2024
mcdonaldseanp
force-pushed
the
PE39351
branch
from
d5ab3a4 to
e7ee5b4
Compare
This commit updates the add_database plan to include the pe-patching and pe-hac databases when it cleans up the original postgres on the primary. The add_database plan uses pg_basebackup to copy the entire contents of the postgres DB from the original primary DB to the new DB node's postgres. That process doesn't individually update a list of databases, so there's no context of "which DBs to move", because it just moves everything. However, during the cleanup process on the original DB That exists on the primary, the plan _does_ need to list the individual internal postgres dbs that need to be deleted.
jhbuchanan45
force-pushed
the
PE39351
branch
from
e7ee5b4 to
d26e059
Compare
Contributor
|
@mcdonaldseanp I've rebased this on main to get CI running with bolt 4. Hopefully by the time you're online CI should be mostly done then |
added 2 commits
December 13, 2024 11:17
ragingra
approved these changes
Dec 16, 2024
abottchen
added a commit
that referenced
this pull request
Apr 10, 2025
Adding the Infra Assistant DB following just as was done with PE Patching in #531.
6 tasks
abottchen
added a commit
that referenced
this pull request
Apr 15, 2025
Adding the Infra Assistant DB following just as was done with PE Patching in #531.
abottchen
added a commit
that referenced
this pull request
Apr 28, 2025
* (PE-40508) Add infra-assistant to add_database plan Adding the Infra Assistant DB following just as was done with PE Patching in #531. * Pinning provsion to released version Currently issue in main causing problem in peadm ci * Apply Yamlfix format changes. --------- Co-authored-by: Neil Anderson <[email protected]> Co-authored-by: ragingra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the add_database plan to include the pe-patching and pe-hac databases when it cleans up the original postgres on the primary.
The add_database plan uses pg_basebackup to copy the entire contents of the postgres DB from the original primary DB to the new DB node's postgres. That process doesn't individually update a list of databases, so there's no context of "which DBs to move", because it just moves everything. However, during the cleanup process on the original DB That exists on the primary, the plan does need to list the individual internal postgres dbs that need to be deleted.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
Changes include test coverage?
Have you updated the documentation?