(PE-40239) Adding check for missing legacy flag #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmalloncares
force-pushed
the
check_legacy_flag
branch
from
c07f2fd to
6d77920
Compare
petergmurphy
approved these changes
Feb 17, 2025
If missing, adding legacy false to compilers
davidmalloncares
force-pushed
the
check_legacy_flag
branch
from
de0511d to
cdeba02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If missing, adding legacy false to compilers
Summary
Updating upgrade.pp to set
peadm_legacy_compilerto false for non-legacy compilers. Tested upgrade on Large env from PEADM v3.24.0/PE 2021.7.7 to latest PEADM/PE 2021.7.9 for the following scenarios:Upgrade plan ran successfully in all cases and set the
peadm_legacy_compilerflag appropriatelyAdditional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
Changes include test coverage?
Have you updated the documentation?