Skip to content

(PE-40379) fix issue on RBAC restore #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

(PE-40379) fix issue on RBAC restore #579

merged 1 commit into from
Apr 14, 2025

Conversation

@davidmalloncares
Copy link
Collaborator

@davidmalloncares davidmalloncares commented Apr 10, 2025

Summary

There were a few issues with restoring rbac:

  1. the code was not looking in the right location to restore the keys.json file
  2. on the system we migrate to the rbac token was revoked so the puppet-db import command was failing

Checklist

  • [] 🟢 Spec tests.
  • [] 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • [] Not needed

Have you updated the documentation?

  • [] Yes, I've updated the appropriate docs
  • Not needed

@davidmalloncares davidmalloncares requested review from a team as code owners April 10, 2025 10:14
@davidmalloncares davidmalloncares force-pushed the PE-40379-rbac-restore-fix branch from 14c5d82 to cbf23b7 Compare April 10, 2025 10:28
@davidmalloncares davidmalloncares force-pushed the PE-40379-rbac-restore-fix branch from cbf23b7 to dd8a1fe Compare April 10, 2025 11:22
B00885424
B00885424 approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@B00885424 B00885424 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. The ubuntu CI failures are all caused by the CI issue and not because of any issues in the PR

@davidmalloncares davidmalloncares merged commit 255b974 into main Apr 14, 2025
101 of 107 checks passed
@davidmalloncares davidmalloncares deleted the PE-40379-rbac-restore-fix branch April 14, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@B00885424 B00885424 B00885424 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidmalloncares @B00885424