(maint) Block lint checks

This commit blocks the top_scope_facts, only_variable_string, and
strinct_indent lint check for portions of manifests/install/windows.pp,
manifests/osfamily/redhat.pp, and manifests/osfamily/suse.pp respectively.

For the top_scope_facts, the check keeps on thinking
`puppet_agent::_expected_package_version` in windows.pp is a fact. For the
only_variable_string, when I try to remove the double quotes from
`"${facts['os']['release']['major']}"`, the conditional no longer works as
expected in redhat.pp. Lastly, for the strict_indent check, it thinks the
indentation for $script in redhat.pp and suse.pp is wrong but it is not.

Author: AriaXLi

manifests/install/windows.pp

@@ -82,6 +82,7 @@
     content => file('puppet_agent/prerequisites_check.ps1'),
   }
 
+# lint:ignore:top_scope_facts
   exec { 'prerequisites_check.ps1':
     command => "${facts['os']['windows']['system32']}\\WindowsPowerShell\\v1.0\\powershell.exe \
                   -ExecutionPolicy Bypass \
@@ -129,6 +130,7 @@
       Exec['prerequisites_check.ps1'],
     ],
   }
+# lint:endignore
 
   # PUP-5480/PE-15037 Cache dir loses inheritable SYSTEM perms
   exec { 'fix inheritable SYSTEM perms':

manifests/osfamily/redhat.pp

@@ -12,6 +12,7 @@
     }
     contain puppet_agent::prepare::package
   } else {
+    # lint:ignore:only_variable_string
     case $facts['os']['name'] {
       'Fedora': {
         $platform_and_version = "fedora/${facts['os']['release']['major']}"
@@ -28,7 +29,8 @@
         $platform_and_version = "el/${facts['os']['release']['major']}"
       }
     }
-    if ($::puppet_agent::is_pe and (!$::puppet_agent::use_alternate_sources)) {
+    # lint:endignore
+    if ($puppet_agent::is_pe and (!$puppet_agent::use_alternate_sources)) {
       $pe_server_version = pe_build_version()
       # Treat Amazon Linux just like Enterprise Linux
       $pe_repo_dir = ($facts['os']['name'] == 'Amazon') ? {
@@ -75,6 +77,7 @@
       $_sslclientkey_path = undef
     }
 
+# lint:ignore:strict_indent
     $legacy_keyname = 'GPG-KEY-puppet'
     $legacy_gpg_path = "/etc/pki/rpm-gpg/RPM-${legacy_keyname}"
     $keyname = 'GPG-KEY-puppet-20250406'

manifests/osfamily/suse.pp

@@ -55,6 +55,7 @@
       }
     }
 
+# lint:ignore:strict_indent
     case $facts['os']['release']['major'] {
       '11', '12', '15': {
         # Import the GPG key
@@ -85,6 +86,7 @@
   rpm --import "${GPG_KEY_PATH}"
 fi
 | SCRIPT
+# lint:endignore
 
         if getvar('::puppet_agent::manage_pki_dir') == true {
           file { ['/etc/pki', '/etc/pki/rpm-gpg']: