Merge pull request #577 from luchihoratiu/MODULES-11123

(MODULES-11123) Avoid loading puppet facts in `install/windows.pp`

Author: GabrielNagy

manifests/install/windows.pp

@@ -109,7 +109,7 @@
                   -NoProfile \
                   -NoLogo \
                   -NonInteractive \
-                  -Command {\$CurrentVersion = [string](facter.bat -p aio_agent_version); \
+                  -Command {\$CurrentVersion = [string](facter.bat aio_agent_version); \
                             if (\$CurrentVersion -eq '${::puppet_agent::_expected_package_version}') { \
                               exit 0; \
                             } \

spec/classes/puppet_agent_windows_install_spec.rb

@@ -82,7 +82,7 @@
             {:package_version => '5.6.7'})
           }
           it {
-            is_expected.to contain_exec('install_puppet.ps1').with_unless(/\-Command {\$CurrentVersion = \[string\]\(facter.bat \-p aio_agent_version\);/)
+            is_expected.to contain_exec('install_puppet.ps1').with_unless(/\-Command {\$CurrentVersion = \[string\]\(facter.bat aio_agent_version\);/)
             is_expected.to contain_exec('install_puppet.ps1').with_unless(/\-Command.*if \(\$CurrentVersion \-eq '5\.6\.7'\) { +exit 0; *} *exit 1; }\.Invoke\(\)/)
           }
         end