Fix Ubuntu 24 puppet-agent installation by using version-specific collections

[gavindidrichsen]

Outstanding tasks

• Verify works as expected with bolt
• What's the behaviour if /opt/puppetlabs/puppet/VERSION already exists? See tim's comment

---

Issue

When running Bolt apply with Ubuntu 24 (noble), if no collection is explicitly specified, the task defaults to using the generic 'puppet' collection, resulting in installing 'puppet-release-noble.deb' instead of the version-specific 'puppet8-release-noble.deb'. This causes installation failures specific to Ubuntu 24, while other OSes work fine.

A previous fix attempted to address this in bolt's apply_prep function, but that placed OS-specific logic in the wrong architectural layer.

Solution

This PR moves the solution to the correct location by enhancing the collection selection logic in install_shell.sh to:

1. First check if a collection was explicitly specified (unchanged)

   • If so, use that collection
   • This maintains backward compatibility and user control

2. If no collection is specified, intelligently determine the appropriate collection:

   • First try to detect Puppet version from /opt/puppetlabs/puppet/VERSION
   • If that fails, try using the puppet --version command
   • Use the major version to set the collection to puppet{major_version} (e.g., puppet8)
   • Only fall back to the generic puppet collection as a last resort

This ensures that:

• Ubuntu 24 installations correctly use puppet8-release-noble.deb
• The target-specific logic is in the proper architectural layer
• We maintain backward compatibility
• We have better logging to track which method was used

[danadoherty639]

Tested this manually and it works

[gavindidrichsen]

Closing this after discussion with Josh Cooper

That was my initial attempt at fixing the ubuntu 24 issue by directly changing the puppet_agent::install. When I discussed this with Josh Cooper he did not want to merge this and explained I should be able to fix the issue by using the correct collection.