Skip to content

(PA-7608) Update artifactory URL instead nightlies for yum source #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
+1 −1
Merged

(PA-7608) Update artifactory URL instead nightlies for yum source #787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tasks/install_shell.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ if [ -n "$PT_yum_source" ]; then
elif [[ "$collection" == "puppetcore"* ]]; then
yum_source='https://yum-puppetcore.puppet.com/public'
elif [ "$nightly" = true ]; then
yum_source='http://nightlies.puppet.com/yum'
yum_source='https://artifactory.delivery.puppetlabs.net:443/artifactory/internal_nightly__local/yum'
Copy link
Contributor

@joshcooper joshcooper Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to do this globally or at least not until a new major version.

Can't the test/caller pass the parameter for now? Alternatively, we could create a puppetcore8-nightly collection and update the {yum,apt,mac,windows}_source. The way the new behavior is strictly opt-in.

Copy link
Contributor Author

@skyamgarp skyamgarp Jul 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay we wanted to test if this is accessible with twingate. Do we need to revert this change?

else
yum_source='http://yum.puppet.com'
fi
Expand Down
Loading