Skip to content

Only ship the minimally required files #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ekohl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Only ship the minimally required files #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions puppetserver-ca.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ Gem::Specification.new do |spec|
spec.summary = %q{A simple CLI tool for interacting with Puppet Server's Certificate Authority}
spec.homepage = "https://github.com/puppetlabs/puppetserver-ca-cli/"

spec.files = `git ls-files -z`.split("\x0").reject do |f|
f.match(%r{^(test|spec|features)/})
spec.files = `git ls-files -z`.split("\x0").select do |f|
f.start_with?('LICENSE', 'README.md', 'lib/')
Copy link

@smortex smortex Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the exe directory is missing here 🤔.

Copy link
Author

@ekohl ekohl Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used gem build and they show up. There was no need to list it twice (other is via executables)

end
spec.bindir = "exe"
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.executables = "puppetserver-ca"
spec.require_paths = ["lib"]

spec.add_runtime_dependency "facter", [">= 2.0.1", "< 5"]
Expand Down