-
Notifications
You must be signed in to change notification settings - Fork 58
updating containers and enabling restic support for azure #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ldaneliukas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some small things to review, great work 👍
correct date for changelog Co-authored-by: Linas Daneliukas <[email protected]>
Co-authored-by: Linas Daneliukas <[email protected]>
Co-authored-by: Linas Daneliukas <[email protected]>
Co-authored-by: Linas Daneliukas <[email protected]>
Co-authored-by: Linas Daneliukas <[email protected]>
…he data should exist in the secret
|
Are we good to get this merged? i'd like to move on to potential restic restore capabilities as well as formally bumping puppet version to 8 but i don't want to start working without a clean branch to avoid conflicts |
|
any news ? |
|
@alagoutte this is merged over in the new openvox helm chart OpenVoxProject/openvox-helm-chart#1 i suspect that given that Puppet OSS is essentially "dead" this repo is unlikely to get much more meaningful updates going forwards - i have already moved my efforts over to the openvox side of this |
Pulling the list of changes from CHANGELOG
the various updates should be self explanatory but to specifically point out the changing container URL and version format for puppetserver/puppetdb as VoxPupuli are deprecating the old container URL in 2025-02
Restic now supports defining an existingSecret (but the chart will not provision it if you do) so that you can securely define the access parameters in a secret going forwards rather than Helm Chart values, the old method still works today (for S3 buckets only!), README is updated to show this with examples
Restic now also supports Azure Workload Identity and Azure Blob storage for backup repo, readme is updated to show an example but configuring workload identity e.g. the configuration of a managed identity and assigning permissions is not detailed in the readme
I have also made some additional notes in the readme to talk about upgrading puppet to v8 as well as clarify the previous notes related to updating the Helm Chart version to avoid confusion
In theory (but untested) the new existingSecret method for restic config allows a user to set any compatible environment value for restic and could therefore support additional backend repos, I have only tested Azure Blob Storage
as all of these changes remain backwards compatible i have only bumped version to 9.6.0 rather than 10.0.0