Skip to content

Conversation

@garrettrowell
Copy link
Contributor

Summary

Double quote the values of environment variables to ensure values containing spaces are properly passed.

https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_hash_tables?view=powershell-7.4#iterating-over-keys-and-values

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@garrettrowell garrettrowell requested a review from a team as a code owner October 16, 2024 17:39
@jordanbreen28
Copy link
Contributor

@garrettrowell thanks for this, nice catch.
Could you rebase off main to get rid of the merge commit and we'll go ahead and merge this in?

@garrettrowell
Copy link
Contributor Author

@jordanbreen28 thanks, this should be rebased now

Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @garrettrowell!

@jordanbreen28 jordanbreen28 merged commit cd3f468 into puppetlabs:main Oct 17, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants